Title: [203636] trunk/Source/WebInspectorUI
- Revision
- 203636
- Author
- nvasil...@apple.com
- Date
- 2016-07-23 00:17:37 -0700 (Sat, 23 Jul 2016)
Log Message
REGRESSION (r202876): Web Inspector: Switching away from Console tab with a lot of messages is slow
https://bugs.webkit.org/show_bug.cgi?id=160112
Reviewed by Joseph Pecoraro.
Showing NavigationSidebar before removing previous TabContentView can be very slow when
TabContentView is ConsoleTabContentView with a lot of messages. The order of operations
(show sidebar, change content view, show sidebar) caused more forced layouts. This patch
reduces the number of forced layouts by changes the order to: show content view, show sidebar,
show sidebar.
* UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser.prototype._tabBarItemSelected):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (203635 => 203636)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-07-23 06:15:22 UTC (rev 203635)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-07-23 07:17:37 UTC (rev 203636)
@@ -1,3 +1,19 @@
+2016-07-23 Nikita Vasilyev <nvasil...@apple.com>
+
+ REGRESSION (r202876): Web Inspector: Switching away from Console tab with a lot of messages is slow
+ https://bugs.webkit.org/show_bug.cgi?id=160112
+
+ Reviewed by Joseph Pecoraro.
+
+ Showing NavigationSidebar before removing previous TabContentView can be very slow when
+ TabContentView is ConsoleTabContentView with a lot of messages. The order of operations
+ (show sidebar, change content view, show sidebar) caused more forced layouts. This patch
+ reduces the number of forced layouts by changes the order to: show content view, show sidebar,
+ show sidebar.
+
+ * UserInterface/Views/TabBrowser.js:
+ (WebInspector.TabBrowser.prototype._tabBarItemSelected):
+
2016-07-20 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Pausing when Debugger tab is closed opens tab in wrong state
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js (203635 => 203636)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2016-07-23 06:15:22 UTC (rev 203635)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2016-07-23 07:17:37 UTC (rev 203636)
@@ -204,8 +204,6 @@
{
var tabContentView = this._tabBar.selectedTabBarItem ? this._tabBar.selectedTabBarItem.representedObject : null;
- this._showNavigationSidebarPanelForTabContentView(tabContentView);
-
if (tabContentView) {
this._recentTabContentViews.remove(tabContentView);
this._recentTabContentViews.unshift(tabContentView);
@@ -221,6 +219,7 @@
console.assert(!this.selectedTabContentView);
}
+ this._showNavigationSidebarPanelForTabContentView(tabContentView);
this._showDetailsSidebarPanelsForTabContentView(tabContentView);
this.dispatchEventToListeners(WebInspector.TabBrowser.Event.SelectedTabContentViewDidChange);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
