Title: [203762] trunk/Source/WebCore
- Revision
- 203762
- Author
- commit-qu...@webkit.org
- Date
- 2016-07-26 22:20:04 -0700 (Tue, 26 Jul 2016)
Log Message
[GTK] ASSERTION FAILED: !m_adoptionIsRequired when Inspector Server is connected
https://bugs.webkit.org/show_bug.cgi?id=160229
Patch by Fujii Hironori <hironori.fu...@sony.com> on 2016-07-26
Reviewed by Carlos Garcia Campos.
An assertion fails because refcount of SocketStreamHandle is
incremented before adoptRef, in the constructor of
SocketStreamHandle. The constructor of SocketStreamHandle needs
to increment recount because it passes this pointer to libsoup.
* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle): Do
relaxAdoptionRequirement() as well as the another constructor.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (203761 => 203762)
--- trunk/Source/WebCore/ChangeLog 2016-07-27 04:27:12 UTC (rev 203761)
+++ trunk/Source/WebCore/ChangeLog 2016-07-27 05:20:04 UTC (rev 203762)
@@ -1,3 +1,19 @@
+2016-07-26 Fujii Hironori <hironori.fu...@sony.com>
+
+ [GTK] ASSERTION FAILED: !m_adoptionIsRequired when Inspector Server is connected
+ https://bugs.webkit.org/show_bug.cgi?id=160229
+
+ Reviewed by Carlos Garcia Campos.
+
+ An assertion fails because refcount of SocketStreamHandle is
+ incremented before adoptRef, in the constructor of
+ SocketStreamHandle. The constructor of SocketStreamHandle needs
+ to increment recount because it passes this pointer to libsoup.
+
+ * platform/network/soup/SocketStreamHandleSoup.cpp:
+ (WebCore::SocketStreamHandle::SocketStreamHandle): Do
+ relaxAdoptionRequirement() as well as the another constructor.
+
2016-07-26 Chris Dumez <cdu...@apple.com>
Move 'dir' attribute from HTMLDocument to Document
Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (203761 => 203762)
--- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2016-07-27 04:27:12 UTC (rev 203761)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2016-07-27 05:20:04 UTC (rev 203762)
@@ -70,6 +70,7 @@
{
LOG(Network, "SocketStreamHandle %p new client %p", this, &m_client);
GRefPtr<GSocketConnection> connection = socketConnection;
+ relaxAdoptionRequirement();
connected(WTFMove(connection));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
