Log Message
[JSC] Remove the first LocalCSE https://bugs.webkit.org/show_bug.cgi?id=160615
Patch by Benjamin Poulain <bpoul...@apple.com> on 2016-08-05 Reviewed by Saam Barati. LocalCSE is the most expensive phase in DFG (excluding FTL). The combination of two LocalCSEs does not seem to pay for its cost. Doing a single LocalCSE is always after ConstantFolding and StrengthReduction is always a win on my machine. * dfg/DFGCleanUpPhase.cpp: (JSC::DFG::CleanUpPhase::run): * dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (204206 => 204207)
--- trunk/Source/_javascript_Core/ChangeLog 2016-08-06 00:46:50 UTC (rev 204206)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-08-06 00:49:25 UTC (rev 204207)
@@ -1,3 +1,21 @@
+2016-08-05 Benjamin Poulain <bpoul...@apple.com>
+
+ [JSC] Remove the first LocalCSE
+ https://bugs.webkit.org/show_bug.cgi?id=160615
+
+ Reviewed by Saam Barati.
+
+ LocalCSE is the most expensive phase in DFG (excluding FTL).
+
+ The combination of two LocalCSEs does not seem to pay for its cost.
+ Doing a single LocalCSE is always after ConstantFolding and StrengthReduction
+ is always a win on my machine.
+
+ * dfg/DFGCleanUpPhase.cpp:
+ (JSC::DFG::CleanUpPhase::run):
+ * dfg/DFGPlan.cpp:
+ (JSC::DFG::Plan::compileInThreadImpl):
+
2016-08-05 Saam Barati <sbar...@apple.com>
various math operations don't properly check for an exception after calling toNumber() on the lhs
Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (204206 => 204207)
--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp 2016-08-06 00:46:50 UTC (rev 204206)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp 2016-08-06 00:49:25 UTC (rev 204207)
@@ -310,7 +310,6 @@
validate(dfg);
performStrengthReduction(dfg);
- performLocalCSE(dfg);
performCPSRethreading(dfg);
performCFA(dfg);
performConstantFolding(dfg);
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
