Title: [204352] trunk/Source/_javascript_Core
- Revision
- 204352
- Author
- benja...@webkit.org
- Date
- 2016-08-10 14:19:03 -0700 (Wed, 10 Aug 2016)
Log Message
[JSC] Remove some useless code I left when rewriting CSE's large maps
https://bugs.webkit.org/show_bug.cgi?id=160720
Patch by Benjamin Poulain <bpoul...@apple.com> on 2016-08-10
Reviewed by Michael Saboff.
* dfg/DFGCSEPhase.cpp:
The maps m_worldMap && m_sideStateMap are useless. They come from the previous
iteration that had weaker constraints.
Also move m_heapMap after m_fallbackStackMap since that is the order
in which they are used in the algorithm.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (204351 => 204352)
--- trunk/Source/_javascript_Core/ChangeLog 2016-08-10 21:15:18 UTC (rev 204351)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-08-10 21:19:03 UTC (rev 204352)
@@ -1,5 +1,19 @@
2016-08-10 Benjamin Poulain <bpoul...@apple.com>
+ [JSC] Remove some useless code I left when rewriting CSE's large maps
+ https://bugs.webkit.org/show_bug.cgi?id=160720
+
+ Reviewed by Michael Saboff.
+
+ * dfg/DFGCSEPhase.cpp:
+ The maps m_worldMap && m_sideStateMap are useless. They come from the previous
+ iteration that had weaker constraints.
+
+ Also move m_heapMap after m_fallbackStackMap since that is the order
+ in which they are used in the algorithm.
+
+2016-08-10 Benjamin Poulain <bpoul...@apple.com>
+
Remove AbstractInterpreter::executeEdges(unsigned), it is no longer used anywhere
https://bugs.webkit.org/show_bug.cgi?id=160708
Modified: trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp (204351 => 204352)
--- trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2016-08-10 21:15:18 UTC (rev 204351)
+++ trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp 2016-08-10 21:19:03 UTC (rev 204352)
@@ -108,9 +108,9 @@
ImpureMap(ImpureMap&& other)
{
- m_heapMap.swap(other.m_heapMap);
m_abstractHeapStackMap.swap(other.m_abstractHeapStackMap);
m_fallbackStackMap.swap(other.m_fallbackStackMap);
+ m_heapMap.swap(other.m_heapMap);
#if !defined(NDEBUG)
m_debugImpureData.swap(other.m_debugImpureData);
#endif
@@ -175,9 +175,9 @@
void clear()
{
- m_heapMap.clear();
m_abstractHeapStackMap.clear();
m_fallbackStackMap.clear();
+ m_heapMap.clear();
#if !defined(NDEBUG)
m_debugImpureData.clear();
#endif
@@ -257,10 +257,6 @@
});
}
- Map m_worldMap;
- Map m_heapMap;
- Map m_sideStateMap;
-
// The majority of Impure Stack Slotsare unique per value.
// This is very useful for fast clobber(), we can just remove the slot addressed by AbstractHeap
// in O(1).
@@ -275,6 +271,8 @@
HashMap<int32_t, std::unique_ptr<ImpureDataSlot>, DefaultHash<int32_t>::Hash, WTF::SignedWithZeroKeyHashTraits<int32_t>> m_abstractHeapStackMap;
Map m_fallbackStackMap;
+ Map m_heapMap;
+
#if !defined(NDEBUG)
HashMap<HeapLocation, LazyNode> m_debugImpureData;
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
