Title: [204633] trunk/Source/_javascript_Core
Revision
204633
Author
[email protected]
Date
2016-08-19 09:41:27 -0700 (Fri, 19 Aug 2016)

Log Message

[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=160995

Avoid setting unknown compile option on source file.

Reviewed by Anders Carlsson.

* CMakeLists.txt:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (204632 => 204633)


--- trunk/Source/_javascript_Core/CMakeLists.txt	2016-08-19 16:08:18 UTC (rev 204632)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2016-08-19 16:41:27 UTC (rev 204633)
@@ -851,7 +851,11 @@
 )
 
 # Extra flags for compile sources can go here.
-set_source_files_properties(runtime/ProxyObject.cpp PROPERTIES COMPILE_FLAGS -fno-optimize-sibling-calls)
+if (NOT MSVC)
+    set_source_files_properties(runtime/ProxyObject.cpp PROPERTIES COMPILE_FLAGS -fno-optimize-sibling-calls)
+else ()
+    # FIXME: Investigate if we need to set a similar flag on Windows.
+endif ()
 
 set(_javascript_Core_OBJECT_LUT_SOURCES
     runtime/ArrayConstructor.cpp

Modified: trunk/Source/_javascript_Core/ChangeLog (204632 => 204633)


--- trunk/Source/_javascript_Core/ChangeLog	2016-08-19 16:08:18 UTC (rev 204632)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-08-19 16:41:27 UTC (rev 204633)
@@ -1,3 +1,14 @@
+2016-08-19  Per Arne Vollan  <[email protected]>
+
+        [Win] Warning fix.
+        https://bugs.webkit.org/show_bug.cgi?id=160995
+
+        Avoid setting unknown compile option on source file.
+
+        Reviewed by Anders Carlsson.
+
+        * CMakeLists.txt:
+
 2016-08-18  Mark Lam  <[email protected]>
 
         ScopedArguments is using the wrong owner object for a write barrier.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to