Title: [204704] trunk/LayoutTests
Revision
204704
Author
commit-qu...@webkit.org
Date
2016-08-22 00:09:51 -0700 (Mon, 22 Aug 2016)

Log Message

LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=160510

Patch by Youenn Fablet <you...@apple.com> on 2016-08-22
Reviewed by Darin Adler.

* http/tests/fetch/fetch-in-worker.js:
(stream.new.ReadableStream): Enqueuing a Uint8Array not a string, so that the fetch promise is not rejected. This should take care of Fail flakiness.
Crash flakiness in Debug mode may still happen due to promise use in Worker.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (204703 => 204704)


--- trunk/LayoutTests/ChangeLog	2016-08-22 07:02:27 UTC (rev 204703)
+++ trunk/LayoutTests/ChangeLog	2016-08-22 07:09:51 UTC (rev 204704)
@@ -1,3 +1,14 @@
+2016-08-22  Youenn Fablet  <you...@apple.com>
+
+        LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=160510
+
+        Reviewed by Darin Adler.
+
+        * http/tests/fetch/fetch-in-worker.js:
+        (stream.new.ReadableStream): Enqueuing a Uint8Array not a string, so that the fetch promise is not rejected. This should take care of Fail flakiness.
+        Crash flakiness in Debug mode may still happen due to promise use in Worker.
+
 2016-08-21  Youenn Fablet  <you...@apple.com>
 
         [Mac] Rebase some failing XMLHttpRequest tests

Modified: trunk/LayoutTests/http/tests/fetch/fetch-in-worker.js (204703 => 204704)


--- trunk/LayoutTests/http/tests/fetch/fetch-in-worker.js	2016-08-22 07:02:27 UTC (rev 204703)
+++ trunk/LayoutTests/http/tests/fetch/fetch-in-worker.js	2016-08-22 07:09:51 UTC (rev 204704)
@@ -10,7 +10,8 @@
     });
 
     var stream = new ReadableStream({"start": function(controller) {
-        controller.enqueue("starting but not closing");
+        controller.enqueue(new Uint8Array(1));
+        // Not closing the stream so that below promise will not fulfill.
     }});
     var promise2 = new Response(stream).text().then(() => {
         postMessage("FAIL: promise 2 resolved");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to