Title: [98352] trunk/Source/WebKit/gtk
- Revision
- 98352
- Author
- commit-qu...@webkit.org
- Date
- 2011-10-25 09:52:50 -0700 (Tue, 25 Oct 2011)
Log Message
[GTK] GtkAdjustment watcher updates adjustments too lazily
https://bugs.webkit.org/show_bug.cgi?id=70180
Patch by Martin Robinson <mrobin...@igalia.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.
Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
means that adjustments will more quickly represent the state of the WebKitWebView
when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.
* WebCoreSupport/GtkAdjustmentWatcher.cpp:
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
with the default priority.
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (98351 => 98352)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-10-25 16:40:29 UTC (rev 98351)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-10-25 16:52:50 UTC (rev 98352)
@@ -1,3 +1,18 @@
+2011-10-25 Martin Robinson <mrobin...@igalia.com>
+
+ [GTK] GtkAdjustment watcher updates adjustments too lazily
+ https://bugs.webkit.org/show_bug.cgi?id=70180
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
+ means that adjustments will more quickly represent the state of the WebKitWebView
+ when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.
+
+ * WebCoreSupport/GtkAdjustmentWatcher.cpp:
+ (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
+ with the default priority.
+
2011-10-24 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] Remove g_thread_init() calls
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp (98351 => 98352)
--- trunk/Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp 2011-10-25 16:40:29 UTC (rev 98351)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp 2011-10-25 16:52:50 UTC (rev 98352)
@@ -83,9 +83,8 @@
// The fact that this method was called means that we need to update the scrollbars, but at the
// time of invocation they are not updated to reflect the scroll yet. We set a short timeout
// here, which means that they will be updated as soon as WebKit returns to the main loop.
- m_updateAdjustmentCallbackId = g_timeout_add_full(G_PRIORITY_HIGH_IDLE + 10, 0,
- reinterpret_cast<GSourceFunc>(updateAdjustmentCallback),
- const_cast<void*>(static_cast<const void*>(this)), 0);
+ m_updateAdjustmentCallbackId = g_timeout_add(0, reinterpret_cast<GSourceFunc>(updateAdjustmentCallback),
+ const_cast<void*>(static_cast<const void*>(this)));
}
static void adjustmentValueChangedCallback(GtkAdjustment* adjustment, GtkAdjustmentWatcher* watcher)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
