Title: [204970] trunk/Source/WebCore
- Revision
- 204970
- Author
- [email protected]
- Date
- 2016-08-25 10:08:41 -0700 (Thu, 25 Aug 2016)
Log Message
DOMTokenList.value should be a stringifier attribute
https://bugs.webkit.org/show_bug.cgi?id=161195
Reviewed by Darin Adler.
DOMTokenList.value should be a stringifier attribute:
- https://dom.spec.whatwg.org/#domtokenlist
No new tests, this change is not observable from the Web.
* html/DOMTokenList.h:
(WebCore::DOMTokenList::toString): Deleted.
* html/DOMTokenList.idl:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::iconSizes): Deleted.
* html/HTMLLinkElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (204969 => 204970)
--- trunk/Source/WebCore/ChangeLog 2016-08-25 16:54:44 UTC (rev 204969)
+++ trunk/Source/WebCore/ChangeLog 2016-08-25 17:08:41 UTC (rev 204970)
@@ -1,3 +1,22 @@
+2016-08-25 Chris Dumez <[email protected]>
+
+ DOMTokenList.value should be a stringifier attribute
+ https://bugs.webkit.org/show_bug.cgi?id=161195
+
+ Reviewed by Darin Adler.
+
+ DOMTokenList.value should be a stringifier attribute:
+ - https://dom.spec.whatwg.org/#domtokenlist
+
+ No new tests, this change is not observable from the Web.
+
+ * html/DOMTokenList.h:
+ (WebCore::DOMTokenList::toString): Deleted.
+ * html/DOMTokenList.idl:
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::iconSizes): Deleted.
+ * html/HTMLLinkElement.h:
+
2016-08-25 Csaba Osztrogonác <[email protected]>
[Mac][cmake] Unreviewed speculative buildfix after r204852, just for fun.
Modified: trunk/Source/WebCore/html/DOMTokenList.h (204969 => 204970)
--- trunk/Source/WebCore/html/DOMTokenList.h 2016-08-25 16:54:44 UTC (rev 204969)
+++ trunk/Source/WebCore/html/DOMTokenList.h 2016-08-25 17:08:41 UTC (rev 204970)
@@ -50,8 +50,6 @@
WEBCORE_EXPORT bool toggle(const AtomicString&, Optional<bool> force, ExceptionCode&);
void replace(const AtomicString& token, const AtomicString& newToken, ExceptionCode&);
- const AtomicString& toString() const { return value(); }
-
Element& element() const { return m_element; }
WEBCORE_EXPORT void setValue(const String&);
Modified: trunk/Source/WebCore/html/DOMTokenList.idl (204969 => 204970)
--- trunk/Source/WebCore/html/DOMTokenList.idl 2016-08-25 16:54:44 UTC (rev 204969)
+++ trunk/Source/WebCore/html/DOMTokenList.idl 2016-08-25 17:08:41 UTC (rev 204970)
@@ -37,9 +37,5 @@
iterable<DOMString>;
- attribute DOMString value;
-
-#if !(defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
- DOMString toString();
-#endif
+ stringifier attribute DOMString value;
};
Modified: trunk/Source/WebCore/html/HTMLLinkElement.cpp (204969 => 204970)
--- trunk/Source/WebCore/html/HTMLLinkElement.cpp 2016-08-25 16:54:44 UTC (rev 204969)
+++ trunk/Source/WebCore/html/HTMLLinkElement.cpp 2016-08-25 17:08:41 UTC (rev 204970)
@@ -501,11 +501,6 @@
return m_relAttribute.iconType;
}
-String HTMLLinkElement::iconSizes()
-{
- return sizes().toString();
-}
-
void HTMLLinkElement::addSubresourceAttributeURLs(ListHashSet<URL>& urls) const
{
HTMLElement::addSubresourceAttributeURLs(urls);
Modified: trunk/Source/WebCore/html/HTMLLinkElement.h (204969 => 204970)
--- trunk/Source/WebCore/html/HTMLLinkElement.h 2016-08-25 16:54:44 UTC (rev 204969)
+++ trunk/Source/WebCore/html/HTMLLinkElement.h 2016-08-25 17:08:41 UTC (rev 204970)
@@ -55,9 +55,6 @@
Optional<LinkIconType> iconType() const;
- // the icon size string as parsed from the HTML attribute
- String iconSizes();
-
CSSStyleSheet* sheet() const { return m_sheet.get(); }
bool styleSheetIsLoading() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
