Title: [205003] trunk/Tools
- Revision
- 205003
- Author
- [email protected]
- Date
- 2016-08-25 22:33:58 -0700 (Thu, 25 Aug 2016)
Log Message
ews queues should update status server when they start processing patch
https://bugs.webkit.org/show_bug.cgi?id=161223
Reviewed by Daniel Bates.
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(StyleQueueTest.test_style_queue_with_style_exception): Same.
(test_style_queue_with_watch_list_exception): Same.
(test_non_valid_patch): Same.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (205002 => 205003)
--- trunk/Tools/ChangeLog 2016-08-26 02:16:41 UTC (rev 205002)
+++ trunk/Tools/ChangeLog 2016-08-26 05:33:58 UTC (rev 205003)
@@ -1,3 +1,19 @@
+2016-08-25 Aakash Jain <[email protected]>
+
+ ews queues should update status server when they start processing patch
+ https://bugs.webkit.org/show_bug.cgi?id=161223
+
+ Reviewed by Daniel Bates.
+
+ * Scripts/webkitpy/tool/commands/queues.py:
+ (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
+ * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+ (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
+ * Scripts/webkitpy/tool/commands/queues_unittest.py:
+ (StyleQueueTest.test_style_queue_with_style_exception): Same.
+ (test_style_queue_with_watch_list_exception): Same.
+ (test_non_valid_patch): Same.
+
2016-08-25 Alex Christensen <[email protected]>
CMake build fix.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (205002 => 205003)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2016-08-26 02:16:41 UTC (rev 205002)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2016-08-26 05:33:58 UTC (rev 205003)
@@ -77,7 +77,8 @@
expected_logs = {
"begin_work_queue": self._default_begin_work_queue_logs(ews.name),
- "process_work_item": """Running: webkit-patch --status-host=example.com clean --port=%(port)s%(architecture)s
+ "process_work_item": """MOCK: update_status: %(name)s Started processing patch
+Running: webkit-patch --status-host=example.com clean --port=%(port)s%(architecture)s
Running: webkit-patch --status-host=example.com update --port=%(port)s%(architecture)s
Running: webkit-patch --status-host=example.com apply-attachment --no-update --non-interactive 10000 --port=%(port)s%(architecture)s
Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --port=%(port)s%(architecture)s
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (205002 => 205003)
--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2016-08-26 02:16:41 UTC (rev 205002)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2016-08-26 05:33:58 UTC (rev 205003)
@@ -445,6 +445,7 @@
return self._next_patch()
def process_work_item(self, patch):
+ self._update_status("Started processing patch", patch)
passed = self.review_patch(patch)
if passed:
self._did_pass(patch)
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py (205002 => 205003)
--- trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py 2016-08-26 02:16:41 UTC (rev 205002)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py 2016-08-26 05:33:58 UTC (rev 205003)
@@ -471,7 +471,8 @@
def test_style_queue_with_style_exception(self):
expected_logs = {
"begin_work_queue": self._default_begin_work_queue_logs("style-queue"),
- "process_work_item": """Running: webkit-patch --status-host=example.com clean
+ "process_work_item": """MOCK: update_status: style-queue Started processing patch
+Running: webkit-patch --status-host=example.com clean
MOCK: update_status: style-queue Cleaned working directory
Running: webkit-patch --status-host=example.com update
MOCK: update_status: style-queue Updated working directory
@@ -493,7 +494,8 @@
def test_style_queue_with_watch_list_exception(self):
expected_logs = {
"begin_work_queue": self._default_begin_work_queue_logs("style-queue"),
- "process_work_item": """Running: webkit-patch --status-host=example.com clean
+ "process_work_item": """MOCK: update_status: style-queue Started processing patch
+Running: webkit-patch --status-host=example.com clean
MOCK: update_status: style-queue Cleaned working directory
Running: webkit-patch --status-host=example.com update
MOCK: update_status: style-queue Updated working directory
@@ -520,7 +522,8 @@
patch = tool.bugs.fetch_attachment(10007) # _patch8, resolved bug, without review flag, not marked obsolete (maybe already landed)
expected_logs = {
"begin_work_queue": self._default_begin_work_queue_logs("style-queue"),
- "process_work_item": """MOCK: update_status: style-queue Error: style-queue did not process patch. Reason: Bug is already closed.
+ "process_work_item": """MOCK: update_status: style-queue Started processing patch
+MOCK: update_status: style-queue Error: style-queue did not process patch. Reason: Bug is already closed.
MOCK: release_work_item: style-queue 10007
""",
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
