Title: [205128] trunk
- Revision
- 205128
- Author
- achristen...@apple.com
- Date
- 2016-08-29 11:26:52 -0700 (Mon, 29 Aug 2016)
Log Message
API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=161317
Reviewed by Brady Eidson.
Source/WebCore:
Added an API test.
* platform/URLParser.cpp:
(WebCore::URLParser::parse):
Turns out, this state can be reached.
Tools:
* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205127 => 205128)
--- trunk/Source/WebCore/ChangeLog 2016-08-29 18:09:07 UTC (rev 205127)
+++ trunk/Source/WebCore/ChangeLog 2016-08-29 18:26:52 UTC (rev 205128)
@@ -1,3 +1,16 @@
+2016-08-29 Alex Christensen <achristen...@webkit.org>
+
+ API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
+ https://bugs.webkit.org/show_bug.cgi?id=161317
+
+ Reviewed by Brady Eidson.
+
+ Added an API test.
+
+ * platform/URLParser.cpp:
+ (WebCore::URLParser::parse):
+ Turns out, this state can be reached.
+
2016-08-29 Youenn Fablet <you...@apple.com>
[Fetch API] Response cloning should structureClone when teeing Response stream
Modified: trunk/Source/WebCore/platform/URLParser.cpp (205127 => 205128)
--- trunk/Source/WebCore/platform/URLParser.cpp 2016-08-29 18:09:07 UTC (rev 205127)
+++ trunk/Source/WebCore/platform/URLParser.cpp 2016-08-29 18:26:52 UTC (rev 205128)
@@ -428,7 +428,6 @@
switch (state) {
case State::SchemeStart:
LOG_FINAL_STATE("SchemeStart");
- ASSERT_NOT_REACHED();
return { };
case State::Scheme:
LOG_FINAL_STATE("Scheme");
Modified: trunk/Tools/ChangeLog (205127 => 205128)
--- trunk/Tools/ChangeLog 2016-08-29 18:09:07 UTC (rev 205127)
+++ trunk/Tools/ChangeLog 2016-08-29 18:26:52 UTC (rev 205128)
@@ -1,3 +1,13 @@
+2016-08-29 Alex Christensen <achristen...@webkit.org>
+
+ API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
+ https://bugs.webkit.org/show_bug.cgi?id=161317
+
+ Reviewed by Brady Eidson.
+
+ * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+ (TestWebKitAPI::TEST_F):
+
2016-08-29 Jer Noble <jer.no...@apple.com>
Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (205127 => 205128)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp 2016-08-29 18:09:07 UTC (rev 205127)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp 2016-08-29 18:26:52 UTC (rev 205128)
@@ -180,6 +180,7 @@
TEST_F(URLParserTest, ParserFailures)
{
shouldFail(" ");
+ shouldFail("");
}
} // namespace TestWebKitAPI
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
