Diff
Modified: trunk/LayoutTests/ChangeLog (205325 => 205326)
--- trunk/LayoutTests/ChangeLog 2016-09-01 22:45:52 UTC (rev 205325)
+++ trunk/LayoutTests/ChangeLog 2016-09-01 23:04:23 UTC (rev 205326)
@@ -1,3 +1,15 @@
+2016-09-01 Ricky Mondello <[email protected]>
+
+ YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
+ https://bugs.webkit.org/show_bug.cgi?id=161478
+ <rdar://problem/28050847>
+
+ Reviewed by Eric Carlson.
+
+ * platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt: Update the URL that was blocked.
+ * platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width-expected.txt: Ditto.
+ * security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt: Ditto.
+
2016-09-01 Devin Rousso <[email protected]>
Web Inspector: add Object.awaitEvent which is like singleFireEventListener but returns a promise
Modified: trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt (205325 => 205326)
--- trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt 2016-09-01 22:45:52 UTC (rev 205325)
+++ trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt 2016-09-01 23:04:23 UTC (rev 205326)
@@ -1,8 +1,8 @@
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US&showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US&showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?showinfo=0
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o
Test transforming youtube flash plugin to youtube iFrame based player. < rdar://problem/11201356>
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width-expected.txt (205325 => 205326)
--- trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width-expected.txt 2016-09-01 22:45:52 UTC (rev 205325)
+++ trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width-expected.txt 2016-09-01 23:04:23 UTC (rev 205326)
@@ -1,9 +1,9 @@
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US&showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US&showinfo=0
-Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US&showinfo=0
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US
+Blocked access to external URL http://www.youtube.com/embed/N0gb9v4LI4o?version=3&hl=en_US
Test embed youtube plugin without height or width attribute. < rdar://problem/12134474>
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt (205325 => 205326)
--- trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt 2016-09-01 22:45:52 UTC (rev 205325)
+++ trunk/LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt 2016-09-01 23:04:23 UTC (rev 205326)
@@ -1,2 +1,2 @@
-Blocked access to external URL https://www.youtube.com/embed/UF8uR6Z6KLc?showinfo=0
+Blocked access to external URL https://www.youtube.com/embed/UF8uR6Z6KLc
Modified: trunk/Source/WebCore/ChangeLog (205325 => 205326)
--- trunk/Source/WebCore/ChangeLog 2016-09-01 22:45:52 UTC (rev 205325)
+++ trunk/Source/WebCore/ChangeLog 2016-09-01 23:04:23 UTC (rev 205326)
@@ -1,3 +1,14 @@
+2016-09-01 Ricky Mondello <[email protected]>
+
+ YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
+ https://bugs.webkit.org/show_bug.cgi?id=161478
+ <rdar://problem/28050847>
+
+ Reviewed by Eric Carlson.
+
+ * Modules/plugins/YouTubePluginReplacement.cpp:
+ (WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL): Stop adding the query parameter.
+
2016-09-01 Mark Lam <[email protected]>
Move some JSObject and JSArray inline functions to their respective Inlines.h files.
Modified: trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp (205325 => 205326)
--- trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp 2016-09-01 22:45:52 UTC (rev 205325)
+++ trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp 2016-09-01 23:04:23 UTC (rev 205326)
@@ -327,13 +327,6 @@
if (query.isEmpty())
query = possibleMalformedQuery;
- // By default, the iframe will display information like the video title and uploader on top of the video. Don't display
- // them if the embeding html doesn't specify it.
- if (!query.isEmpty() && !query.contains("showinfo"))
- query.append("&showinfo=0");
- else
- query = "showinfo=0";
-
// Append the query string if it is valid.
StringBuilder finalURL;
if (isYouTubeShortenedURL)
Modified: trunk/Tools/ChangeLog (205325 => 205326)
--- trunk/Tools/ChangeLog 2016-09-01 22:45:52 UTC (rev 205325)
+++ trunk/Tools/ChangeLog 2016-09-01 23:04:23 UTC (rev 205326)
@@ -1,3 +1,14 @@
+2016-09-01 Ricky Mondello <[email protected]>
+
+ YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
+ https://bugs.webkit.org/show_bug.cgi?id=161478
+ <rdar://problem/28050847>
+
+ Reviewed by Eric Carlson.
+
+ * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
+ (TestWebKitAPI::TEST_F): Update expected results.
+
2016-09-01 Anders Carlsson <[email protected]>
add BlockPtr::fromCallable
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp (205325 => 205326)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp 2016-09-01 22:45:52 UTC (rev 205325)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp 2016-09-01 23:04:23 UTC (rev 205326)
@@ -52,18 +52,18 @@
EXPECT_TRUE(test("https://www.youtube.com", "https://www.youtube.com"));
// Basic YouTube video links, expected to be transformed.
- EXPECT_TRUE(test("https://www.youtube.com/v/dQw4w9WgXcQ", "https://www.youtube.com/embed/dQw4w9WgXcQ?showinfo=0"));
- EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ", "http://www.youtube.com/embed/dQw4w9WgXcQ?showinfo=0"));
- EXPECT_TRUE(test("https://youtube.com/v/dQw4w9WgXcQ", "https://youtube.com/embed/dQw4w9WgXcQ?showinfo=0"));
- EXPECT_TRUE(test("http://youtube.com/v/dQw4w9WgXcQ", "http://youtube.com/embed/dQw4w9WgXcQ?showinfo=0"));
+ EXPECT_TRUE(test("https://www.youtube.com/v/dQw4w9WgXcQ", "https://www.youtube.com/embed/dQw4w9WgXcQ"));
+ EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ", "http://www.youtube.com/embed/dQw4w9WgXcQ"));
+ EXPECT_TRUE(test("https://youtube.com/v/dQw4w9WgXcQ", "https://youtube.com/embed/dQw4w9WgXcQ"));
+ EXPECT_TRUE(test("http://youtube.com/v/dQw4w9WgXcQ", "http://youtube.com/embed/dQw4w9WgXcQ"));
// With start time, preserved.
- EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ?start=4", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&showinfo=0"));
- EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ?start=4&fs=1", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&fs=1&showinfo=0"));
+ EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ?start=4", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4"));
+ EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ?start=4&fs=1", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&fs=1"));
// With an invalid query (see & instead of ?), we preserve and fix the query.
- EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ&start=4", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&showinfo=0"));
- EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ&start=4&fs=1", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&fs=1&showinfo=0"));
+ EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ&start=4", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4"));
+ EXPECT_TRUE(test("http://www.youtube.com/v/dQw4w9WgXcQ&start=4&fs=1", "http://www.youtube.com/embed/dQw4w9WgXcQ?start=4&fs=1"));
// Non-Flash URL is untouched.
EXPECT_TRUE(test("https://www.youtube.com/embed/dQw4w9WgXcQ", "https://www.youtube.com/embed/dQw4w9WgXcQ"));
