Title: [205427] trunk/Source
- Revision
- 205427
- Author
- joep...@webkit.org
- Date
- 2016-09-04 23:41:59 -0700 (Sun, 04 Sep 2016)
Log Message
Remove unnecessary RetainPtr.
Review comments on earlier change.
Source/WebKit/mac:
* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]):
Source/WebKit2:
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _defaultAnimationController]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (205426 => 205427)
--- trunk/Source/WebKit/mac/ChangeLog 2016-09-05 05:02:38 UTC (rev 205426)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-09-05 06:41:59 UTC (rev 205427)
@@ -1,3 +1,12 @@
+2016-09-04 Joseph Pecoraro <pecor...@apple.com>
+
+ Remove unnecessary RetainPtr.
+
+ Review comments on earlier change.
+
+ * WebView/WebImmediateActionController.mm:
+ (-[WebImmediateActionController _defaultAnimationController]):
+
2016-09-03 Darin Adler <da...@apple.com>
Streamline DOMImplementation, and move it to our new DOM exception system
Modified: trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm (205426 => 205427)
--- trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2016-09-05 05:02:38 UTC (rev 205426)
+++ trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2016-09-05 06:41:59 UTC (rev 205427)
@@ -255,10 +255,8 @@
- (id <NSImmediateActionAnimationController>)_defaultAnimationController
{
- if (_contentPreventsDefault) {
- RetainPtr<WebAnimationController> dummyController = adoptNS([[WebAnimationController alloc] init]);
- return dummyController.autorelease();
- }
+ if (_contentPreventsDefault)
+ return [[[WebAnimationController alloc] init] autorelease];
NSURL *url = ""
NSString *absoluteURLString = [url absoluteString];
Modified: trunk/Source/WebKit2/ChangeLog (205426 => 205427)
--- trunk/Source/WebKit2/ChangeLog 2016-09-05 05:02:38 UTC (rev 205426)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-05 06:41:59 UTC (rev 205427)
@@ -1,3 +1,12 @@
+2016-09-04 Joseph Pecoraro <pecor...@apple.com>
+
+ Remove unnecessary RetainPtr.
+
+ Review comments on earlier change.
+
+ * UIProcess/mac/WKImmediateActionController.mm:
+ (-[WKImmediateActionController _defaultAnimationController]):
+
2016-09-04 Dan Bernstein <m...@apple.com>
[Cocoa] Wrapping XPC service execution in os_activity is no longer needed
Modified: trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm (205426 => 205427)
--- trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm 2016-09-05 05:02:38 UTC (rev 205426)
+++ trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm 2016-09-05 06:41:59 UTC (rev 205427)
@@ -269,10 +269,8 @@
- (id <NSImmediateActionAnimationController>)_defaultAnimationController
{
- if (_contentPreventsDefault) {
- RetainPtr<WKAnimationController> dummyController = adoptNS([[WKAnimationController alloc] init]);
- return dummyController.autorelease();
- }
+ if (_contentPreventsDefault)
+ return [[[WKAnimationController alloc] init] autorelease];
RefPtr<API::HitTestResult> hitTestResult = [self _webHitTestResult];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
