Title: [98432] trunk/LayoutTests
Revision
98432
Author
rn...@webkit.org
Date
2011-10-25 23:20:40 -0700 (Tue, 25 Oct 2011)

Log Message

Flaky Test: editing/pasteboard/copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=61813

Reviewed by Adam Barth.

The flakiness was caused by the fact test didn't wait until iframe finish loading.

HTML5 section 4.8.2. the iframe element (http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):
    When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
    of the iframe's browsing context's active document, the iframe must delay the load event of its document.

Since an image doesn't require an active parser, it does not delay the load event of the document.

* editing/pasteboard/copy-standalone-image.html:
* platform/chromium/test_expectations.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (98431 => 98432)


--- trunk/LayoutTests/ChangeLog	2011-10-26 05:55:27 UTC (rev 98431)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 06:20:40 UTC (rev 98432)
@@ -1,3 +1,21 @@
+2011-10-25  Ryosuke Niwa  <rn...@webkit.org>
+
+        Flaky Test: editing/pasteboard/copy-standalone-image.html
+        https://bugs.webkit.org/show_bug.cgi?id=61813
+
+        Reviewed by Adam Barth.
+
+        The flakiness was caused by the fact test didn't wait until iframe finish loading.
+
+        HTML5 section 4.8.2. the iframe element (http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):
+            When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
+            of the iframe's browsing context's active document, the iframe must delay the load event of its document.
+
+        Since an image doesn't require an active parser, it does not delay the load event of the document.
+
+        * editing/pasteboard/copy-standalone-image.html:
+        * platform/chromium/test_expectations.txt:
+
 2011-10-25  Xiaomei Ji  <x...@chromium.org>
 
         Disable editing/selection/move-by-word-visually-inline-block-positioned-element.html in QT after r98428.

Modified: trunk/LayoutTests/editing/pasteboard/copy-standalone-image.html (98431 => 98432)


--- trunk/LayoutTests/editing/pasteboard/copy-standalone-image.html	2011-10-26 05:55:27 UTC (rev 98431)
+++ trunk/LayoutTests/editing/pasteboard/copy-standalone-image.html	2011-10-26 06:20:40 UTC (rev 98432)
@@ -25,14 +25,14 @@
 }
 </style>
 </head>
-<body _onload_="editingTest()">
+<body>
 
 <p>This is an automatic test of copying an image document.</p>
 <p>To perform this test manually, click once in the image frame, choose Edit -> Copy
 then click in the red box and paste the image. If the image pastes successfully the
 test is passed.</p>
 
-<iframe name="imageframe" src=""
+<iframe name="imageframe" src="" _onload_="editingTest()">
 </iframe>
 
 <div id="dest" class="editable" contenteditable="true"> </div>

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98431 => 98432)


--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-26 05:55:27 UTC (rev 98431)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-26 06:20:40 UTC (rev 98432)
@@ -668,7 +668,6 @@
 
 // Flaky
 BUGCR31803 LINUX MAC : editing/inserting/12882.html = PASS IMAGE
-BUGCR31803 MAC WIN : editing/pasteboard/copy-standalone-image.html = PASS TEXT IMAGE IMAGE+TEXT
 
 // Tests added in r69269.
 // Apple-Mac port corrects "notationl" to "notational" automatically?
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to