Title: [205767] trunk/Source/_javascript_Core
Revision
205767
Author
fpi...@apple.com
Date
2016-09-09 14:20:02 -0700 (Fri, 09 Sep 2016)

Log Message

jsc.cpp should call initializeMainThread() to make sure that GC thread assertions work
https://bugs.webkit.org/show_bug.cgi?id=161801

Reviewed by Keith Miller.
        
The GC has debug assertions that certain things don't happen on GC threads. Those assertions
are no-ops unless initializeGCThreads() is called, and I think the most canonical way to do
that is to call initializeMainThread().

* jsc.cpp:
(jscmain):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (205766 => 205767)


--- trunk/Source/_javascript_Core/ChangeLog	2016-09-09 20:57:50 UTC (rev 205766)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-09 21:20:02 UTC (rev 205767)
@@ -1,3 +1,17 @@
+2016-09-09  Filip Pizlo  <fpi...@apple.com>
+
+        jsc.cpp should call initializeMainThread() to make sure that GC thread assertions work
+        https://bugs.webkit.org/show_bug.cgi?id=161801
+
+        Reviewed by Keith Miller.
+        
+        The GC has debug assertions that certain things don't happen on GC threads. Those assertions
+        are no-ops unless initializeGCThreads() is called, and I think the most canonical way to do
+        that is to call initializeMainThread().
+
+        * jsc.cpp:
+        (jscmain):
+
 2016-09-09  Saam Barati  <sbar...@apple.com>
 
         Make hasOwnProperty ALWAYS_INLINE

Modified: trunk/Source/_javascript_Core/jsc.cpp (205766 => 205767)


--- trunk/Source/_javascript_Core/jsc.cpp	2016-09-09 20:57:50 UTC (rev 205766)
+++ trunk/Source/_javascript_Core/jsc.cpp	2016-09-09 21:20:02 UTC (rev 205767)
@@ -2559,9 +2559,7 @@
     CommandLine options(argc, argv);
 
     // Initialize JSC before getting VM.
-#if ENABLE(SAMPLING_REGIONS)
     WTF::initializeMainThread();
-#endif
     JSC::initializeThreading();
 
     VM* vm = &VM::create(LargeHeap).leakRef();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to