Title: [205825] trunk
- Revision
- 205825
- Author
- commit-qu...@webkit.org
- Date
- 2016-09-12 14:42:31 -0700 (Mon, 12 Sep 2016)
Log Message
AX: WKWebView for macOS does not allow configuration of tabsToLinks
https://bugs.webkit.org/show_bug.cgi?id=161394
Patch by DAN SAUNDERS <da...@microsoft.com> on 2016-09-12
Reviewed by Anders Carlsson.
Source/WebKit2:
* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences encodeWithCoder:]):
(-[WKPreferences initWithCoder:]):
(-[WKPreferences tabFocusesLinks]):
(-[WKPreferences setTabFocusesLinks:]):
Tools:
* TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (205824 => 205825)
--- trunk/Source/WebKit2/ChangeLog 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-12 21:42:31 UTC (rev 205825)
@@ -1,3 +1,17 @@
+2016-09-12 DAN SAUNDERS <da...@microsoft.com>
+
+ AX: WKWebView for macOS does not allow configuration of tabsToLinks
+ https://bugs.webkit.org/show_bug.cgi?id=161394
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/Cocoa/WKPreferences.h:
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences encodeWithCoder:]):
+ (-[WKPreferences initWithCoder:]):
+ (-[WKPreferences tabFocusesLinks]):
+ (-[WKPreferences setTabFocusesLinks:]):
+
2016-09-12 Saam Barati <sbar...@apple.com>
Add WebKit support for an option in Safari's debug menu similar to "Get Bytecode Profile" but for the Sampling Profiler's data
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h (205824 => 205825)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h 2016-09-12 21:42:31 UTC (rev 205825)
@@ -63,6 +63,13 @@
@discussion The default value is NO.
*/
@property (nonatomic) BOOL plugInsEnabled;
+
+/*!
+ @property tabFocusesLinks
+ @abstract If tabFocusesLinks is YES, the tab key will focus links and form controls.
+ The option key temporarily reverses this preference.
+ */
+@property (nonatomic) BOOL tabFocusesLinks WK_API_AVAILABLE(macosx(WK_MAC_TBA));
#endif
@end
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (205824 => 205825)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2016-09-12 21:42:31 UTC (rev 205825)
@@ -66,6 +66,7 @@
#if PLATFORM(MAC)
[coder encodeBool:self.javaEnabled forKey:@"javaEnabled"];
[coder encodeBool:self.plugInsEnabled forKey:@"plugInsEnabled"];
+ [coder encodeBool:self.tabFocusesLinks forKey:@"tabFocusesLinks"];
#endif
}
@@ -81,6 +82,7 @@
#if PLATFORM(MAC)
self.javaEnabled = [coder decodeBoolForKey:@"javaEnabled"];
self.plugInsEnabled = [coder decodeBoolForKey:@"plugInsEnabled"];
+ self.tabFocusesLinks = [coder decodeBoolForKey:@"tabFocusesLinks"];
#endif
return self;
@@ -140,6 +142,16 @@
_preferences->setPluginsEnabled(plugInsEnabled);
}
+- (BOOL)tabFocusesLinks
+{
+ return _preferences->tabsToLinks();
+}
+
+- (void)setTabFocusesLinks:(BOOL)tabFocusesLinks
+{
+ _preferences->setTabsToLinks(tabFocusesLinks);
+}
+
#endif
#pragma mark WKObject protocol implementation
Modified: trunk/Tools/ChangeLog (205824 => 205825)
--- trunk/Tools/ChangeLog 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Tools/ChangeLog 2016-09-12 21:42:31 UTC (rev 205825)
@@ -1,3 +1,13 @@
+2016-09-12 DAN SAUNDERS <da...@microsoft.com>
+
+ AX: WKWebView for macOS does not allow configuration of tabsToLinks
+ https://bugs.webkit.org/show_bug.cgi?id=161394
+
+ Reviewed by Anders Carlsson.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
+ (TEST):
+
2016-09-12 Alex Christensen <achristen...@webkit.org>
Remove trailing control characters and spaces before parsing a URL
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm (205824 => 205825)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm 2016-09-12 21:42:31 UTC (rev 205825)
@@ -51,6 +51,7 @@
[a setJavaScriptCanOpenWindowsAutomatically:NO];
[a setJavaEnabled:YES];
[a setPlugInsEnabled:YES];
+ [a setTabFocusesLinks:YES];
#endif
auto b = encodeAndDecode(a.get());
@@ -62,6 +63,7 @@
#if PLATFORM(MAC)
EXPECT_EQ([a javaEnabled], [b javaEnabled]);
EXPECT_EQ([a plugInsEnabled], [b plugInsEnabled]);
+ EXPECT_EQ([a tabFocusesLinks], [b tabFocusesLinks]);
#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
