Title: [205973] trunk/Source/WebCore
- Revision
- 205973
- Author
- [email protected]
- Date
- 2016-09-15 09:32:15 -0700 (Thu, 15 Sep 2016)
Log Message
[css-grid] Fix a dangling reference
https://bugs.webkit.org/show_bug.cgi?id=161739
Reviewed by Alexey Proskuryakov.
The code was trying to get a reference to a private attribute of a temporary object returned
by gridTrackSize().
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::assumedRowsSizeForOrthogonalChild):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205972 => 205973)
--- trunk/Source/WebCore/ChangeLog 2016-09-15 15:51:18 UTC (rev 205972)
+++ trunk/Source/WebCore/ChangeLog 2016-09-15 16:32:15 UTC (rev 205973)
@@ -1,5 +1,18 @@
2016-09-15 Sergio Villar Senin <[email protected]>
+ [css-grid] Fix a dangling reference
+ https://bugs.webkit.org/show_bug.cgi?id=161739
+
+ Reviewed by Alexey Proskuryakov.
+
+ The code was trying to get a reference to a private attribute of a temporary object returned
+ by gridTrackSize().
+
+ * rendering/RenderGrid.cpp:
+ (WebCore::RenderGrid::assumedRowsSizeForOrthogonalChild):
+
+2016-09-15 Sergio Villar Senin <[email protected]>
+
Unreviewed, rolling out r205966.
Triggered some assertions
Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (205972 => 205973)
--- trunk/Source/WebCore/rendering/RenderGrid.cpp 2016-09-15 15:51:18 UTC (rev 205972)
+++ trunk/Source/WebCore/rendering/RenderGrid.cpp 2016-09-15 16:32:15 UTC (rev 205973)
@@ -2010,7 +2010,7 @@
bool gridAreaIsIndefinite = false;
LayoutUnit containingBlockAvailableSize = containingBlockLogicalHeightForContent(ExcludeMarginBorderPadding);
for (auto trackPosition : span) {
- const GridLength& maxTrackSize = gridTrackSize(ForRows, trackPosition, sizingOperation).maxTrackBreadth();
+ GridLength maxTrackSize = gridTrackSize(ForRows, trackPosition, sizingOperation).maxTrackBreadth();
if (maxTrackSize.isContentSized() || maxTrackSize.isFlex())
gridAreaIsIndefinite = true;
else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
