Title: [206005] trunk/Source/WebInspectorUI
- Revision
- 206005
- Author
- [email protected]
- Date
- 2016-09-15 17:20:03 -0700 (Thu, 15 Sep 2016)
Log Message
Web Inspector: Use more global color variables in TreeOutline and DataGrid
https://bugs.webkit.org/show_bug.cgi?id=161940
<rdar://problem/28292555>
Reviewed by Brian Burg.
* UserInterface/Views/DataGrid.css:
(.data-grid tr.selected):
(.data-grid:matches(:focus, .force-focus) tr.selected):
Use global color vars.
* UserInterface/Views/TreeOutline.css:
(.tree-outline .item.selected):
Use global color vars.
(body.window-inactive .tree-outline .item.selected): Deleted.
Not needed. Unfocused color is the same when window is inactive.
* UserInterface/Views/Variables.css:
(:root):
Add --selected-background-color-unfocused.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (206004 => 206005)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-09-15 23:42:17 UTC (rev 206004)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-09-16 00:20:03 UTC (rev 206005)
@@ -1,3 +1,26 @@
+2016-09-15 Matt Baker <[email protected]>
+
+ Web Inspector: Use more global color variables in TreeOutline and DataGrid
+ https://bugs.webkit.org/show_bug.cgi?id=161940
+ <rdar://problem/28292555>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DataGrid.css:
+ (.data-grid tr.selected):
+ (.data-grid:matches(:focus, .force-focus) tr.selected):
+ Use global color vars.
+
+ * UserInterface/Views/TreeOutline.css:
+ (.tree-outline .item.selected):
+ Use global color vars.
+ (body.window-inactive .tree-outline .item.selected): Deleted.
+ Not needed. Unfocused color is the same when window is inactive.
+
+ * UserInterface/Views/Variables.css:
+ (:root):
+ Add --selected-background-color-unfocused.
+
2016-09-14 Matt Baker <[email protected]>
Web Inspector: Call frame is sometimes not selected in Debugger sidebar on initial pause
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (206004 => 206005)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2016-09-15 23:42:17 UTC (rev 206004)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2016-09-16 00:20:03 UTC (rev 206005)
@@ -272,13 +272,13 @@
}
.data-grid tr.selected {
- background-color: hsl(0, 0%, 83%) !important;
+ background-color: var(--selected-background-color-unfocused) !important;
color: inherit !important;
}
.data-grid:matches(:focus, .force-focus) tr.selected {
- background-color: hsl(209, 100%, 49%) !important;
- color: white !important;
+ background-color: var(--selected-background-color) !important;
+ color: var(--selected-foreground-color) !important;
}
.data-grid tr:not(.parent) td.disclosure {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css (206004 => 206005)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css 2016-09-15 23:42:17 UTC (rev 206004)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css 2016-09-16 00:20:03 UTC (rev 206005)
@@ -152,7 +152,7 @@
}
.tree-outline .item.selected {
- background-color: hsl(0, 0%, 83%);
+ background-color: var(--selected-background-color-unfocused);
}
.tree-outline:matches(:focus, .force-focus) .item.selected {
@@ -160,10 +160,6 @@
background-color: var(--selected-background-color);
}
-body.window-inactive .tree-outline .item.selected {
- background-color: hsl(0, 0%, 83%);
-}
-
.tree-outline .item .titles {
position: relative;
top: 2px;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css (206004 => 206005)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2016-09-15 23:42:17 UTC (rev 206004)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2016-09-16 00:20:03 UTC (rev 206005)
@@ -34,6 +34,7 @@
--selected-foreground-color: white;
--selected-background-color: hsl(212, 92%, 54%);
+ --selected-background-color-unfocused: hsl(0, 0%, 83%);
--selected-background-color-active: hsl(218, 85%, 52%);
--selected-background-color-hover: hsla(212, 92%, 54%, 0.5);
--selected-background-color-highlight: hsla(0, 0%, 100%, 0.3);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
