Title: [206239] trunk/Source/_javascript_Core
- Revision
- 206239
- Author
- commit-qu...@webkit.org
- Date
- 2016-09-21 15:52:37 -0700 (Wed, 21 Sep 2016)
Log Message
Inline function only used in one place
https://bugs.webkit.org/show_bug.cgi?id=162363
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-09-21
Reviewed by Saam Barati.
* bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForInNode::emitMultiLoopBytecode):
* parser/Nodes.h:
No need for the extra function, it adds no clarification.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (206238 => 206239)
--- trunk/Source/_javascript_Core/ChangeLog 2016-09-21 22:51:52 UTC (rev 206238)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-09-21 22:52:37 UTC (rev 206239)
@@ -1,3 +1,16 @@
+2016-09-21 Joseph Pecoraro <pecor...@apple.com>
+
+ Inline function only used in one place
+ https://bugs.webkit.org/show_bug.cgi?id=162363
+
+ Reviewed by Saam Barati.
+
+ * bytecompiler/NodesCodegen.cpp:
+ (JSC::ForInNode::emitBytecode):
+ (JSC::ForInNode::emitMultiLoopBytecode):
+ * parser/Nodes.h:
+ No need for the extra function, it adds no clarification.
+
2016-09-21 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r206222 and r206227.
Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (206238 => 206239)
--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2016-09-21 22:51:52 UTC (rev 206238)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2016-09-21 22:52:37 UTC (rev 206239)
@@ -2685,7 +2685,7 @@
RELEASE_ASSERT_NOT_REACHED();
}
-void ForInNode::emitMultiLoopBytecode(BytecodeGenerator& generator, RegisterID* dst)
+void ForInNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
{
if (!m_lexpr->isAssignResolveNode() && !m_lexpr->isAssignmentLocation()) {
emitThrowReferenceError(generator, ASCIILiteral("Left side of for-in statement is not a reference."));
@@ -2835,11 +2835,6 @@
generator.emitProfileControlFlow(profilerEndOffset);
}
-void ForInNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
-{
- this->emitMultiLoopBytecode(generator, dst);
-}
-
// ------------------------------ ForOfNode ------------------------------------
void ForOfNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
{
Modified: trunk/Source/_javascript_Core/parser/Nodes.h (206238 => 206239)
--- trunk/Source/_javascript_Core/parser/Nodes.h 2016-09-21 22:51:52 UTC (rev 206238)
+++ trunk/Source/_javascript_Core/parser/Nodes.h 2016-09-21 22:52:37 UTC (rev 206239)
@@ -1475,7 +1475,6 @@
private:
RegisterID* tryGetBoundLocal(BytecodeGenerator&);
void emitLoopHeader(BytecodeGenerator&, RegisterID* propertyName);
- void emitMultiLoopBytecode(BytecodeGenerator&, RegisterID* dst);
void emitBytecode(BytecodeGenerator&, RegisterID* = 0) override;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
