Title: [206387] trunk/Source/WebCore
- Revision
- 206387
- Author
- commit-qu...@webkit.org
- Date
- 2016-09-26 12:55:08 -0700 (Mon, 26 Sep 2016)
Log Message
[GTK][EFL] imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html is failing
https://bugs.webkit.org/show_bug.cgi?id=162547
Patch by Youenn Fablet <you...@apple.com> on 2016-09-26
Reviewed by Carlos Garcia Campos.
Covered by LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html now passing.
* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::createTestingSession): Setting a default Accept-Language value.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206386 => 206387)
--- trunk/Source/WebCore/ChangeLog 2016-09-26 19:11:17 UTC (rev 206386)
+++ trunk/Source/WebCore/ChangeLog 2016-09-26 19:55:08 UTC (rev 206387)
@@ -1,3 +1,15 @@
+2016-09-26 Youenn Fablet <you...@apple.com>
+
+ [GTK][EFL] imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=162547
+
+ Reviewed by Carlos Garcia Campos.
+
+ Covered by LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html now passing.
+
+ * platform/network/soup/SoupNetworkSession.cpp:
+ (WebCore::SoupNetworkSession::createTestingSession): Setting a default Accept-Language value.
+
2016-09-26 Mark Lam <mark....@apple.com>
Added RETURN_IF_EXCEPTION() macro and use it for exception checks.
Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (206386 => 206387)
--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2016-09-26 19:11:17 UTC (rev 206386)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2016-09-26 19:55:08 UTC (rev 206387)
@@ -63,8 +63,11 @@
std::unique_ptr<SoupNetworkSession> SoupNetworkSession::createTestingSession()
{
- GRefPtr<SoupCookieJar> cookieJar = adoptGRef(createPrivateBrowsingCookieJar());
- return std::unique_ptr<SoupNetworkSession>(new SoupNetworkSession(cookieJar.get()));
+ auto cookieJar = adoptGRef(createPrivateBrowsingCookieJar());
+ auto newSoupSession = std::unique_ptr<SoupNetworkSession>(new SoupNetworkSession(cookieJar.get()));
+ // FIXME: Creating a testing session is losing soup session values set when initializing the network process.
+ g_object_set(newSoupSession.get(), "accept-language", "en-us", nullptr);
+ return newSoupSession;
}
std::unique_ptr<SoupNetworkSession> SoupNetworkSession::createForSoupSession(SoupSession* soupSession)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
