Title: [98533] trunk/LayoutTests
- Revision
- 98533
- Author
- rn...@webkit.org
- Date
- 2011-10-26 21:56:44 -0700 (Wed, 26 Oct 2011)
Log Message
Console message in copy-standalone-image-crash.html bleeds into the result of copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=70957
Reviewed by Ojan Vafai.
The bug was caused by the delayed hideDiv call in a mousedown event listener.
Fixed the bug by not attaching this event listener inside DRT or TestRunner.
* editing/pasteboard/copy-standalone-image-crash.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (98532 => 98533)
--- trunk/LayoutTests/ChangeLog 2011-10-27 01:51:50 UTC (rev 98532)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 04:56:44 UTC (rev 98533)
@@ -1,3 +1,15 @@
+2011-10-26 Ryosuke Niwa <rn...@webkit.org>
+
+ Console message in copy-standalone-image-crash.html bleeds into the result of copy-standalone-image.html
+ https://bugs.webkit.org/show_bug.cgi?id=70957
+
+ Reviewed by Ojan Vafai.
+
+ The bug was caused by the delayed hideDiv call in a mousedown event listener.
+ Fixed the bug by not attaching this event listener inside DRT or TestRunner.
+
+ * editing/pasteboard/copy-standalone-image-crash.html:
+
2011-10-26 Julien Chaffraix <jchaffr...@webkit.org>
Massive gardening.
Modified: trunk/LayoutTests/editing/pasteboard/copy-standalone-image-crash.html (98532 => 98533)
--- trunk/LayoutTests/editing/pasteboard/copy-standalone-image-crash.html 2011-10-27 01:51:50 UTC (rev 98532)
+++ trunk/LayoutTests/editing/pasteboard/copy-standalone-image-crash.html 2011-10-27 04:56:44 UTC (rev 98533)
@@ -35,14 +35,11 @@
document.getElementById("DIV").style.display="none";
}
-// this is for manual testing only
-function delayhide() {
- setTimeout(hideDiv, 100);
-}
-
function doTest() {
- if (!window.layoutTestController)
+ if (!window.layoutTestController) {
+ document.body.addEventListener('mousedown', function () {setTimeout(hideDiv, 100)}, false);
return;
+ }
var image = document.getElementById("IMG");
@@ -59,7 +56,7 @@
</script>
</head>
-<body _onload_="doTest()" _onmousedown_="delayhide()">
+<body _onload_="doTest()">
This is an automated test case for bug <a href=""
If you wish to test manually, mouseover to image, activate context menu, wait for the image to disappear and then click copy image.<br>
There should be no crash.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
