Title: [207018] trunk/Source/WebCore
- Revision
- 207018
- Author
- wenson_hs...@apple.com
- Date
- 2016-10-10 13:52:54 -0700 (Mon, 10 Oct 2016)
Log Message
Address some review feedback from r206979 and r207010
https://bugs.webkit.org/show_bug.cgi?id=163236
Reviewed by Tim Horton.
In TypingCommand.h, some methods on TypingCommand should be marked as final to reflect the fact that they
override methods in CompositeEditCommand. Also, HTMLFormControlElement::dispatchFormControlInputEvent does not
need to specify HTMLElement::dispatchInputEvent() when calling dispatchInputEvent().
No new tests, since there is no behavior change.
* editing/TypingCommand.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (207017 => 207018)
--- trunk/Source/WebCore/ChangeLog 2016-10-10 20:33:46 UTC (rev 207017)
+++ trunk/Source/WebCore/ChangeLog 2016-10-10 20:52:54 UTC (rev 207018)
@@ -1,3 +1,20 @@
+2016-10-10 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Address some review feedback from r206979 and r207010
+ https://bugs.webkit.org/show_bug.cgi?id=163236
+
+ Reviewed by Tim Horton.
+
+ In TypingCommand.h, some methods on TypingCommand should be marked as final to reflect the fact that they
+ override methods in CompositeEditCommand. Also, HTMLFormControlElement::dispatchFormControlInputEvent does not
+ need to specify HTMLElement::dispatchInputEvent() when calling dispatchInputEvent().
+
+ No new tests, since there is no behavior change.
+
+ * editing/TypingCommand.h:
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
+
2016-10-10 Chris Dumez <cdu...@apple.com>
Update MessageEvent to stop using legacy [ConstructorTemplate=Event]
Modified: trunk/Source/WebCore/editing/TypingCommand.h (207017 => 207018)
--- trunk/Source/WebCore/editing/TypingCommand.h 2016-10-10 20:33:46 UTC (rev 207017)
+++ trunk/Source/WebCore/editing/TypingCommand.h 2016-10-10 20:52:54 UTC (rev 207018)
@@ -104,16 +104,16 @@
static RefPtr<TypingCommand> lastTypingCommandIfStillOpenForTyping(Frame&);
- void doApply();
- bool isTypingCommand() const;
- bool preservesTypingStyle() const { return m_preservesTypingStyle; }
- bool shouldRetainAutocorrectionIndicator() const
+ void doApply() final;
+ bool isTypingCommand() const final;
+ bool preservesTypingStyle() const final { return m_preservesTypingStyle; }
+ bool shouldRetainAutocorrectionIndicator() const final
{
ASSERT(isTopLevelCommand());
return m_shouldRetainAutocorrectionIndicator;
}
- void setShouldRetainAutocorrectionIndicator(bool retain) { m_shouldRetainAutocorrectionIndicator = retain; }
- bool shouldStopCaretBlinking() const { return true; }
+ void setShouldRetainAutocorrectionIndicator(bool retain) final { m_shouldRetainAutocorrectionIndicator = retain; }
+ bool shouldStopCaretBlinking() const final { return true; }
void setShouldPreventSpellChecking(bool prevent) { m_shouldPreventSpellChecking = prevent; }
String inputEventTypeName() const final;
@@ -133,8 +133,8 @@
void insertParagraphSeparatorInQuotedContentAndNotifyAccessibility();
void insertParagraphSeparatorAndNotifyAccessibility();
- bool willApplyCommand();
- void didApplyCommand();
+ bool willApplyCommand() final;
+ void didApplyCommand() final;
ETypingCommand m_commandType;
EditAction m_currentTypingEditAction;
Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (207017 => 207018)
--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2016-10-10 20:33:46 UTC (rev 207017)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2016-10-10 20:52:54 UTC (rev 207018)
@@ -326,7 +326,7 @@
void HTMLFormControlElement::dispatchFormControlInputEvent()
{
setChangedSinceLastFormControlChangeEvent(true);
- HTMLElement::dispatchInputEvent();
+ dispatchInputEvent();
}
bool HTMLFormControlElement::isDisabledFormControl() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
