Title: [207160] trunk/Source/WebKit/mac
- Revision
- 207160
- Author
- [email protected]
- Date
- 2016-10-11 13:18:27 -0700 (Tue, 11 Oct 2016)
Log Message
REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
https://bugs.webkit.org/show_bug.cgi?id=163259
<rdar://problem/28680515>
Reviewed by Jer Noble.
In WebKit1 on iOS we want to require user action to load and play videos by default and
allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
can load and play without being initiated by a user action.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize the default value of the deprecated preference
WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
preference takes precedence over the values of its replacement preferences
WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (207159 => 207160)
--- trunk/Source/WebKit/mac/ChangeLog 2016-10-11 20:17:58 UTC (rev 207159)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-10-11 20:18:27 UTC (rev 207160)
@@ -1,5 +1,24 @@
2016-10-11 Daniel Bates <[email protected]>
+ REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
+ https://bugs.webkit.org/show_bug.cgi?id=163259
+ <rdar://problem/28680515>
+
+ Reviewed by Jer Noble.
+
+ In WebKit1 on iOS we want to require user action to load and play videos by default and
+ allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
+ Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
+ can load and play without being initiated by a user action.
+
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
+ WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
+ preference takes precedence over the values of its replacement preferences
+ WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
+
+2016-10-11 Daniel Bates <[email protected]>
+
[iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
https://bugs.webkit.org/show_bug.cgi?id=163244
<rdar://problem/27250015>
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (207159 => 207160)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-10-11 20:17:58 UTC (rev 207159)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-10-11 20:18:27 UTC (rev 207160)
@@ -545,6 +545,7 @@
#if HAVE(AVKIT)
[NSNumber numberWithBool:YES], WebKitAVKitEnabled,
#endif
+ [NSNumber numberWithBool:YES], WebKitRequiresUserGestureForMediaPlaybackPreferenceKey,
[NSNumber numberWithBool:NO], WebKitRequiresUserGestureForVideoPlaybackPreferenceKey,
[NSNumber numberWithBool:NO], WebKitRequiresUserGestureForAudioPlaybackPreferenceKey,
[NSNumber numberWithLongLong:WebCore::ApplicationCacheStorage::noQuota()], WebKitApplicationCacheTotalQuota,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
