Title: [208044] trunk
- Revision
- 208044
- Author
- [email protected]
- Date
- 2016-10-28 05:24:35 -0700 (Fri, 28 Oct 2016)
Log Message
[CMake] Changing enabled features should trigger recompiling all IDL
https://bugs.webkit.org/show_bug.cgi?id=164121
Patch by Fujii Hironori <[email protected]> on 2016-10-28
Reviewed by Michael Catanzaro.
Changing enabled features should trigger recompiling all IDL
because some of them use #if. generate-bindings-all.pl was
introduced in <http://trac.webkit.org/changeset/207617>. Before
this change, updating supplemental_dependency.tmp triggered
recompiling all IDL. Changing enabled features usually involves
adding or removing IDL files. As the result, all IDL would be
recompiled. After the change, adding or removing IDL does not
trigger recompiling all IDL. So, we need to explicitly trigger
recompiling all IDL if enabled features are changed.
* Source/cmake/WebKitMacros.cmake(GENERATE_BINDINGS): Added
cmakeconfig.h to extra dependencies.
Modified Paths
Diff
Modified: trunk/ChangeLog (208043 => 208044)
--- trunk/ChangeLog 2016-10-28 11:14:51 UTC (rev 208043)
+++ trunk/ChangeLog 2016-10-28 12:24:35 UTC (rev 208044)
@@ -1,3 +1,23 @@
+2016-10-28 Fujii Hironori <[email protected]>
+
+ [CMake] Changing enabled features should trigger recompiling all IDL
+ https://bugs.webkit.org/show_bug.cgi?id=164121
+
+ Reviewed by Michael Catanzaro.
+
+ Changing enabled features should trigger recompiling all IDL
+ because some of them use #if. generate-bindings-all.pl was
+ introduced in <http://trac.webkit.org/changeset/207617>. Before
+ this change, updating supplemental_dependency.tmp triggered
+ recompiling all IDL. Changing enabled features usually involves
+ adding or removing IDL files. As the result, all IDL would be
+ recompiled. After the change, adding or removing IDL does not
+ trigger recompiling all IDL. So, we need to explicitly trigger
+ recompiling all IDL if enabled features are changed.
+
+ * Source/cmake/WebKitMacros.cmake(GENERATE_BINDINGS): Added
+ cmakeconfig.h to extra dependencies.
+
2016-10-26 Carlos Garcia Campos <[email protected]>
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.15.1 release.
Modified: trunk/Source/cmake/WebKitMacros.cmake (208043 => 208044)
--- trunk/Source/cmake/WebKitMacros.cmake 2016-10-28 11:14:51 UTC (rev 208043)
+++ trunk/Source/cmake/WebKitMacros.cmake 2016-10-28 12:24:35 UTC (rev 208044)
@@ -106,6 +106,9 @@
set(common_generator_dependencies
${WEBCORE_DIR}/bindings/scripts/generate-bindings.pl
${SCRIPTS_BINDINGS}
+ # Changing enabled features should trigger recompiling all IDL files
+ # because some of them use #if.
+ ${CMAKE_BINARY_DIR}/cmakeconfig.h
)
if (EXISTS ${WEBCORE_DIR}/bindings/scripts/CodeGenerator${arg_GENERATOR}.pm)
list(APPEND common_generator_dependencies ${WEBCORE_DIR}/bindings/scripts/CodeGenerator${arg_GENERATOR}.pm)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
