Title: [208204] trunk/LayoutTests
- Revision
- 208204
- Author
- commit-qu...@webkit.org
- Date
- 2016-10-31 17:47:12 -0700 (Mon, 31 Oct 2016)
Log Message
Remove test workaround now that original issue is fixed
https://bugs.webkit.org/show_bug.cgi?id=164255
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-10-31
Reviewed by Saam Barati.
* inspector/debugger/resources/log-pause-location.js:
(TestPage.registerInitializer.window.logResolvedBreakpointLinesWithContext):
(TestPage.registerInitializer.window.logLinesWithContext):
(TestPage.registerInitializer.String.prototype.myPadStart): Deleted.
Use the real String.prototype.padStart now that it is fixed.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (208203 => 208204)
--- trunk/LayoutTests/ChangeLog 2016-11-01 00:46:52 UTC (rev 208203)
+++ trunk/LayoutTests/ChangeLog 2016-11-01 00:47:12 UTC (rev 208204)
@@ -1,3 +1,16 @@
+2016-10-31 Joseph Pecoraro <pecor...@apple.com>
+
+ Remove test workaround now that original issue is fixed
+ https://bugs.webkit.org/show_bug.cgi?id=164255
+
+ Reviewed by Saam Barati.
+
+ * inspector/debugger/resources/log-pause-location.js:
+ (TestPage.registerInitializer.window.logResolvedBreakpointLinesWithContext):
+ (TestPage.registerInitializer.window.logLinesWithContext):
+ (TestPage.registerInitializer.String.prototype.myPadStart): Deleted.
+ Use the real String.prototype.padStart now that it is fixed.
+
2016-10-31 Ryosuke Niwa <rn...@webkit.org>
Enable custom elements by default everywhere
Modified: trunk/LayoutTests/inspector/debugger/resources/log-pause-location.js (208203 => 208204)
--- trunk/LayoutTests/inspector/debugger/resources/log-pause-location.js 2016-11-01 00:46:52 UTC (rev 208203)
+++ trunk/LayoutTests/inspector/debugger/resources/log-pause-location.js 2016-11-01 00:47:12 UTC (rev 208204)
@@ -2,15 +2,6 @@
let lines = [];
let linesSourceCode = null;
- // Switch back to String.prototype.padStart once this is fixed:
- // FIXME: <https://webkit.org/b/161944> stringProtoFuncRepeatCharacter will return `null` when it should not
- String.prototype.myPadStart = function(desired) {
- let length = this.length;
- if (length >= desired)
- return this;
- return " ".repeat(desired - length) + this;
- };
-
function insertCaretIntoStringAtIndex(str, index, caret="|") {
return str.slice(0, index) + caret + str.slice(index);
}
@@ -98,7 +89,7 @@
lineContent = insertCaretIntoStringAtIndex(lineContent, resolvedLocation.columnNumber, resolvedCaret);
}
- let number = lineNumber.toString().myPadStart(3);
+ let number = lineNumber.toString().padStart(3);
InspectorTest.log(`${prefix}${number} ${lineContent}`);
}
}
@@ -118,7 +109,7 @@
let active = lineNumber === location.lineNumber;
let prefix = active ? " -> " : " ";
- let number = lineNumber.toString().myPadStart(3);
+ let number = lineNumber.toString().padStart(3);
lineContent = active ? insertCaretIntoStringAtIndex(lineContent, location.columnNumber) : lineContent;
InspectorTest.log(`${prefix}${number} ${lineContent}`);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
