Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (209200 => 209201)
--- trunk/Source/_javascript_Core/ChangeLog 2016-12-01 21:45:31 UTC (rev 209200)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-12-01 21:47:34 UTC (rev 209201)
@@ -1,5 +1,40 @@
2016-12-01 Geoffrey Garen <gga...@apple.com>
+ Renamed EvalCodeCache => DirectEvalCodeCache
+ https://bugs.webkit.org/show_bug.cgi?id=165271
+
+ Reviewed by Saam Barati.
+
+ We only use this cache for DirectEval, not IndirectEval.
+
+ * _javascript_Core.xcodeproj/project.pbxproj:
+ * bytecode/CodeBlock.cpp:
+ (JSC::DirectEvalCodeCache::visitAggregate):
+ (JSC::CodeBlock::stronglyVisitStrongReferences):
+ (JSC::EvalCodeCache::visitAggregate): Deleted.
+ * bytecode/CodeBlock.h:
+ (JSC::CodeBlock::directEvalCodeCache):
+ (JSC::CodeBlock::evalCodeCache): Deleted.
+ * bytecode/DirectEvalCodeCache.h: Copied from Source/_javascript_Core/bytecode/EvalCodeCache.h.
+ (JSC::EvalCodeCache::CacheKey::CacheKey): Deleted.
+ (JSC::EvalCodeCache::CacheKey::hash): Deleted.
+ (JSC::EvalCodeCache::CacheKey::isEmptyValue): Deleted.
+ (JSC::EvalCodeCache::CacheKey::operator==): Deleted.
+ (JSC::EvalCodeCache::CacheKey::isHashTableDeletedValue): Deleted.
+ (JSC::EvalCodeCache::CacheKey::Hash::hash): Deleted.
+ (JSC::EvalCodeCache::CacheKey::Hash::equal): Deleted.
+ (JSC::EvalCodeCache::tryGet): Deleted.
+ (JSC::EvalCodeCache::set): Deleted.
+ (JSC::EvalCodeCache::isEmpty): Deleted.
+ (JSC::EvalCodeCache::clear): Deleted.
+ * bytecode/EvalCodeCache.h: Removed.
+ * interpreter/Interpreter.cpp:
+ (JSC::eval):
+ * runtime/DirectEvalExecutable.cpp:
+ (JSC::DirectEvalExecutable::create):
+
+2016-12-01 Geoffrey Garen <gga...@apple.com>
+
Removed some unnecessary indirection in code generation
https://bugs.webkit.org/show_bug.cgi?id=165264
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (209200 => 209201)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2016-12-01 21:45:31 UTC (rev 209200)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2016-12-01 21:47:34 UTC (rev 209201)
@@ -1552,7 +1552,7 @@
969A072B0ED1CE6900F1F681 /* RegisterID.h in Headers */ = {isa = PBXBuildFile; fileRef = 969A07280ED1CE6900F1F681 /* RegisterID.h */; };
969A07960ED1D3AE00F1F681 /* CodeBlock.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 969A07900ED1D3AE00F1F681 /* CodeBlock.cpp */; settings = {COMPILER_FLAGS = "-fno-strict-aliasing"; }; };
969A07970ED1D3AE00F1F681 /* CodeBlock.h in Headers */ = {isa = PBXBuildFile; fileRef = 969A07910ED1D3AE00F1F681 /* CodeBlock.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 969A07980ED1D3AE00F1F681 /* EvalCodeCache.h in Headers */ = {isa = PBXBuildFile; fileRef = 969A07920ED1D3AE00F1F681 /* EvalCodeCache.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 969A07980ED1D3AE00F1F681 /* DirectEvalCodeCache.h in Headers */ = {isa = PBXBuildFile; fileRef = 969A07920ED1D3AE00F1F681 /* DirectEvalCodeCache.h */; settings = {ATTRIBUTES = (Private, ); }; };
969A07990ED1D3AE00F1F681 /* Instruction.h in Headers */ = {isa = PBXBuildFile; fileRef = 969A07930ED1D3AE00F1F681 /* Instruction.h */; settings = {ATTRIBUTES = (Private, ); }; };
969A079A0ED1D3AE00F1F681 /* Opcode.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 969A07940ED1D3AE00F1F681 /* Opcode.cpp */; };
969A079B0ED1D3AE00F1F681 /* Opcode.h in Headers */ = {isa = PBXBuildFile; fileRef = 969A07950ED1D3AE00F1F681 /* Opcode.h */; };
@@ -4015,7 +4015,7 @@
969A07280ED1CE6900F1F681 /* RegisterID.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RegisterID.h; sourceTree = "<group>"; };
969A07900ED1D3AE00F1F681 /* CodeBlock.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CodeBlock.cpp; sourceTree = "<group>"; };
969A07910ED1D3AE00F1F681 /* CodeBlock.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CodeBlock.h; sourceTree = "<group>"; };
- 969A07920ED1D3AE00F1F681 /* EvalCodeCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EvalCodeCache.h; sourceTree = "<group>"; };
+ 969A07920ED1D3AE00F1F681 /* DirectEvalCodeCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DirectEvalCodeCache.h; sourceTree = "<group>"; };
969A07930ED1D3AE00F1F681 /* Instruction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Instruction.h; sourceTree = "<group>"; };
969A07940ED1D3AE00F1F681 /* Opcode.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Opcode.cpp; sourceTree = "<group>"; };
969A07950ED1D3AE00F1F681 /* Opcode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Opcode.h; sourceTree = "<group>"; };
@@ -7201,7 +7201,7 @@
E3BFD0BA1DAF807C0065DEA2 /* DOMJITAccessCasePatchpointParams.h */,
14AD91121DCA97FD0014F9FE /* EvalCodeBlock.cpp */,
14AD91061DCA92940014F9FE /* EvalCodeBlock.h */,
- 969A07920ED1D3AE00F1F681 /* EvalCodeCache.h */,
+ 969A07920ED1D3AE00F1F681 /* DirectEvalCodeCache.h */,
14142E521B796EDD00F4BF4B /* ExecutableInfo.h */,
0F56A1D415001CF2002992B1 /* ExecutionCounter.cpp */,
0F56A1D115000F31002992B1 /* ExecutionCounter.h */,
@@ -8197,7 +8197,7 @@
BC02E98D0E183E38000F9297 /* ErrorInstance.h in Headers */,
BC02E90F0E1839DB000F9297 /* ErrorPrototype.h in Headers */,
996B731B1BDA08D100331B84 /* ErrorPrototype.lut.h in Headers */,
- 969A07980ED1D3AE00F1F681 /* EvalCodeCache.h in Headers */,
+ 969A07980ED1D3AE00F1F681 /* DirectEvalCodeCache.h in Headers */,
A54982041891D0B00081E5B8 /* EventLoop.h in Headers */,
FE1C0FFD1B193E9800B53FCA /* Exception.h in Headers */,
0F12DE101979D5FD0006FF4E /* ExceptionFuzz.h in Headers */,
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (209200 => 209201)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2016-12-01 21:45:31 UTC (rev 209200)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2016-12-01 21:47:34 UTC (rev 209201)
@@ -1797,17 +1797,6 @@
macro(functionExpressions) \
macro(constantRegisters)
-#define FOR_EACH_MEMBER_VECTOR_RARE_DATA(macro) \
- macro(regexps) \
- macro(functions) \
- macro(exceptionHandlers) \
- macro(switchJumpTables) \
- macro(stringSwitchJumpTables) \
- macro(evalCodeCache) \
- macro(expressionInfo) \
- macro(lineInfo) \
- macro(callReturnIndexVector)
-
template<typename T>
static size_t sizeInBytes(const Vector<T>& vector)
{
@@ -2487,7 +2476,7 @@
m_argumentValueProfiles = RefCountedArray<ValueProfile>(newValue);
}
-void EvalCodeCache::visitAggregate(SlotVisitor& visitor)
+void DirectEvalCodeCache::visitAggregate(SlotVisitor& visitor)
{
EvalCacheMap::iterator end = m_cacheMap.end();
for (EvalCacheMap::iterator ptr = m_cacheMap.begin(); ptr != end; ++ptr)
@@ -3132,7 +3121,7 @@
visitor.append(&m_ownerExecutable);
visitor.append(&m_unlinkedCode);
if (m_rareData)
- m_rareData->m_evalCodeCache.visitAggregate(visitor);
+ m_rareData->m_directEvalCodeCache.visitAggregate(visitor);
visitor.appendValues(m_constantRegisters.data(), m_constantRegisters.size());
for (size_t i = 0; i < m_functionExprs.size(); ++i)
visitor.append(&m_functionExprs[i]);
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (209200 => 209201)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2016-12-01 21:45:31 UTC (rev 209200)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2016-12-01 21:47:34 UTC (rev 209201)
@@ -42,7 +42,7 @@
#include "DFGCommon.h"
#include "DFGExitProfile.h"
#include "DeferredCompilationCallback.h"
-#include "EvalCodeCache.h"
+#include "DirectEvalCodeCache.h"
#include "EvalExecutable.h"
#include "ExecutionCounter.h"
#include "ExpressionRangeInfo.h"
@@ -616,7 +616,7 @@
StringJumpTable& addStringSwitchJumpTable() { createRareDataIfNecessary(); m_rareData->m_stringSwitchJumpTables.append(StringJumpTable()); return m_rareData->m_stringSwitchJumpTables.last(); }
StringJumpTable& stringSwitchJumpTable(int tableIndex) { RELEASE_ASSERT(m_rareData); return m_rareData->m_stringSwitchJumpTables[tableIndex]; }
- EvalCodeCache& evalCodeCache() { createRareDataIfNecessary(); return m_rareData->m_evalCodeCache; }
+ DirectEvalCodeCache& directEvalCodeCache() { createRareDataIfNecessary(); return m_rareData->m_directEvalCodeCache; }
enum ShrinkMode {
// Shrink prior to generating machine code that may point directly into vectors.
@@ -870,7 +870,7 @@
Vector<SimpleJumpTable> m_switchJumpTables;
Vector<StringJumpTable> m_stringSwitchJumpTables;
- EvalCodeCache m_evalCodeCache;
+ DirectEvalCodeCache m_directEvalCodeCache;
};
void clearExceptionHandlers()
Copied: trunk/Source/_javascript_Core/bytecode/DirectEvalCodeCache.h (from rev 209200, trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h) (0 => 209201)
--- trunk/Source/_javascript_Core/bytecode/DirectEvalCodeCache.h (rev 0)
+++ trunk/Source/_javascript_Core/bytecode/DirectEvalCodeCache.h 2016-12-01 21:47:34 UTC (rev 209201)
@@ -0,0 +1,114 @@
+/*
+ * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * 3. Neither the name of Apple Inc. ("Apple") nor the names of
+ * its contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+#include "DirectEvalExecutable.h"
+#include <wtf/HashMap.h>
+#include <wtf/RefPtr.h>
+#include <wtf/text/StringHash.h>
+
+namespace JSC {
+
+ class SlotVisitor;
+
+ class DirectEvalCodeCache {
+ public:
+ class CacheKey {
+ public:
+ CacheKey(const String& source, CallSiteIndex callSiteIndex)
+ : m_source(source.impl())
+ , m_callSiteIndex(callSiteIndex)
+ {
+ }
+
+ CacheKey(WTF::HashTableDeletedValueType)
+ : m_source(WTF::HashTableDeletedValue)
+ {
+ }
+
+ CacheKey() = default;
+
+ unsigned hash() const { return m_source->hash() ^ m_callSiteIndex.bits(); }
+
+ bool isEmptyValue() const { return !m_source; }
+
+ bool operator==(const CacheKey& other) const
+ {
+ return m_callSiteIndex == other.m_callSiteIndex && WTF::equal(m_source.get(), other.m_source.get());
+ }
+
+ bool isHashTableDeletedValue() const { return m_source.isHashTableDeletedValue(); }
+
+ struct Hash {
+ static unsigned hash(const CacheKey& key)
+ {
+ return key.hash();
+ }
+ static bool equal(const CacheKey& lhs, const CacheKey& rhs)
+ {
+ return lhs == rhs;
+ }
+ static const bool safeToCompareToEmptyOrDeleted = false;
+ };
+
+ typedef SimpleClassHashTraits<CacheKey> HashTraits;
+
+ private:
+ RefPtr<StringImpl> m_source;
+ CallSiteIndex m_callSiteIndex;
+ };
+
+ DirectEvalExecutable* tryGet(const String& evalSource, CallSiteIndex callSiteIndex)
+ {
+ return m_cacheMap.fastGet(CacheKey(evalSource, callSiteIndex)).get();
+ }
+
+ void set(ExecState* exec, JSCell* owner, const String& evalSource, CallSiteIndex callSiteIndex, DirectEvalExecutable* evalExecutable)
+ {
+ if (m_cacheMap.size() < maxCacheEntries)
+ m_cacheMap.set(CacheKey(evalSource, callSiteIndex), WriteBarrier<DirectEvalExecutable>(exec->vm(), owner, evalExecutable));
+ }
+
+ bool isEmpty() const { return m_cacheMap.isEmpty(); }
+
+ void visitAggregate(SlotVisitor&);
+
+ void clear()
+ {
+ m_cacheMap.clear();
+ }
+
+ private:
+ static const int maxCacheEntries = 64;
+
+ typedef HashMap<CacheKey, WriteBarrier<DirectEvalExecutable>, CacheKey::Hash, CacheKey::HashTraits> EvalCacheMap;
+ EvalCacheMap m_cacheMap;
+ };
+
+} // namespace JSC
Deleted: trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h (209200 => 209201)
--- trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h 2016-12-01 21:45:31 UTC (rev 209200)
+++ trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h 2016-12-01 21:47:34 UTC (rev 209201)
@@ -1,114 +0,0 @@
-/*
- * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- * 3. Neither the name of Apple Inc. ("Apple") nor the names of
- * its contributors may be used to endorse or promote products derived
- * from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#pragma once
-
-#include "DirectEvalExecutable.h"
-#include <wtf/HashMap.h>
-#include <wtf/RefPtr.h>
-#include <wtf/text/StringHash.h>
-
-namespace JSC {
-
- class SlotVisitor;
-
- class EvalCodeCache {
- public:
- class CacheKey {
- public:
- CacheKey(const String& source, CallSiteIndex callSiteIndex)
- : m_source(source.impl())
- , m_callSiteIndex(callSiteIndex)
- {
- }
-
- CacheKey(WTF::HashTableDeletedValueType)
- : m_source(WTF::HashTableDeletedValue)
- {
- }
-
- CacheKey() = default;
-
- unsigned hash() const { return m_source->hash() ^ m_callSiteIndex.bits(); }
-
- bool isEmptyValue() const { return !m_source; }
-
- bool operator==(const CacheKey& other) const
- {
- return m_callSiteIndex == other.m_callSiteIndex && WTF::equal(m_source.get(), other.m_source.get());
- }
-
- bool isHashTableDeletedValue() const { return m_source.isHashTableDeletedValue(); }
-
- struct Hash {
- static unsigned hash(const CacheKey& key)
- {
- return key.hash();
- }
- static bool equal(const CacheKey& lhs, const CacheKey& rhs)
- {
- return lhs == rhs;
- }
- static const bool safeToCompareToEmptyOrDeleted = false;
- };
-
- typedef SimpleClassHashTraits<CacheKey> HashTraits;
-
- private:
- RefPtr<StringImpl> m_source;
- CallSiteIndex m_callSiteIndex;
- };
-
- DirectEvalExecutable* tryGet(const String& evalSource, CallSiteIndex callSiteIndex)
- {
- return m_cacheMap.fastGet(CacheKey(evalSource, callSiteIndex)).get();
- }
-
- void set(ExecState* exec, JSCell* owner, const String& evalSource, CallSiteIndex callSiteIndex, DirectEvalExecutable* evalExecutable)
- {
- if (m_cacheMap.size() < maxCacheEntries)
- m_cacheMap.set(CacheKey(evalSource, callSiteIndex), WriteBarrier<DirectEvalExecutable>(exec->vm(), owner, evalExecutable));
- }
-
- bool isEmpty() const { return m_cacheMap.isEmpty(); }
-
- void visitAggregate(SlotVisitor&);
-
- void clear()
- {
- m_cacheMap.clear();
- }
-
- private:
- static const int maxCacheEntries = 64;
-
- typedef HashMap<CacheKey, WriteBarrier<DirectEvalExecutable>, CacheKey::Hash, CacheKey::HashTraits> EvalCacheMap;
- EvalCacheMap m_cacheMap;
- };
-
-} // namespace JSC
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (209200 => 209201)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2016-12-01 21:45:31 UTC (rev 209200)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2016-12-01 21:47:34 UTC (rev 209201)
@@ -37,9 +37,9 @@
#include "Heap.h"
#include "Debugger.h"
#include "DebuggerCallFrame.h"
+#include "DirectEvalCodeCache.h"
#include "ErrorInstance.h"
#include "EvalCodeBlock.h"
-#include "EvalCodeCache.h"
#include "Exception.h"
#include "ExceptionHelpers.h"
#include "FunctionCodeBlock.h"
@@ -131,7 +131,7 @@
else
evalContextType = EvalContextType::None;
- DirectEvalExecutable* eval = callerCodeBlock->evalCodeCache().tryGet(programSource, callerCallSiteIndex);
+ DirectEvalExecutable* eval = callerCodeBlock->directEvalCodeCache().tryGet(programSource, callerCallSiteIndex);
if (!eval) {
if (!callerCodeBlock->isStrictMode()) {
if (programSource.is8Bit()) {
@@ -154,7 +154,7 @@
if (!eval)
return jsUndefined();
- callerCodeBlock->evalCodeCache().set(callFrame, callerCodeBlock, programSource, callerCallSiteIndex, eval);
+ callerCodeBlock->directEvalCodeCache().set(callFrame, callerCodeBlock, programSource, callerCallSiteIndex, eval);
}
JSValue thisValue = callerFrame->thisValue();
Modified: trunk/Source/_javascript_Core/runtime/DirectEvalExecutable.cpp (209200 => 209201)
--- trunk/Source/_javascript_Core/runtime/DirectEvalExecutable.cpp 2016-12-01 21:45:31 UTC (rev 209200)
+++ trunk/Source/_javascript_Core/runtime/DirectEvalExecutable.cpp 2016-12-01 21:47:34 UTC (rev 209201)
@@ -53,7 +53,7 @@
JSParserStrictMode strictMode = executable->isStrictMode() ? JSParserStrictMode::Strict : JSParserStrictMode::NotStrict;
DebuggerMode debuggerMode = globalObject->hasInteractiveDebugger() ? DebuggerOn : DebuggerOff;
- // We don't bother with CodeCache here because direct eval uses a specialized EvalCodeCache.
+ // We don't bother with CodeCache here because direct eval uses a specialized DirectEvalCodeCache.
UnlinkedEvalCodeBlock* unlinkedEvalCode = generateUnlinkedCodeBlock<UnlinkedEvalCodeBlock>(
vm, executable, executable->source(), strictMode, JSParserScriptMode::Classic, debuggerMode, error, evalContextType, variablesUnderTDZ);
