Title: [209305] trunk/LayoutTests
- Revision
- 209305
- Author
- hy...@apple.com
- Date
- 2016-12-03 13:43:04 -0800 (Sat, 03 Dec 2016)
Log Message
[CSS Parser] Remove Inspector test of Bison errors
https://bugs.webkit.org/show_bug.cgi?id=165362
Reviewed by Simon Fraser.
The old parser logs invalid property declaration errors whenever a Bison error
occurs. This catches only a fraction of declaration errors,
since Bison accepts practically everything and leaves it up to the specific
parser functions to determine validity of a property.
The new parser does not have this error reporting. The old reporting will be
removed from CSSParser when the new parser turns on. This patch removes the
test of Bison errors.
* inspector/console/css-source-locations-expected.txt: Removed.
* inspector/console/css-source-locations.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (209304 => 209305)
--- trunk/LayoutTests/ChangeLog 2016-12-03 21:22:49 UTC (rev 209304)
+++ trunk/LayoutTests/ChangeLog 2016-12-03 21:43:04 UTC (rev 209305)
@@ -1,3 +1,22 @@
+2016-12-03 Dave Hyatt <hy...@apple.com>
+
+ [CSS Parser] Remove Inspector test of Bison errors
+ https://bugs.webkit.org/show_bug.cgi?id=165362
+
+ Reviewed by Simon Fraser.
+
+ The old parser logs invalid property declaration errors whenever a Bison error
+ occurs. This catches only a fraction of declaration errors,
+ since Bison accepts practically everything and leaves it up to the specific
+ parser functions to determine validity of a property.
+
+ The new parser does not have this error reporting. The old reporting will be
+ removed from CSSParser when the new parser turns on. This patch removes the
+ test of Bison errors.
+
+ * inspector/console/css-source-locations-expected.txt: Removed.
+ * inspector/console/css-source-locations.html: Removed.
+
2016-12-02 Sam Weinig <s...@webkit.org>
optional sequence values not handled correctly by binding generator
Deleted: trunk/LayoutTests/inspector/console/css-source-locations-expected.txt (209304 => 209305)
--- trunk/LayoutTests/inspector/console/css-source-locations-expected.txt 2016-12-03 21:22:49 UTC (rev 209304)
+++ trunk/LayoutTests/inspector/console/css-source-locations-expected.txt 2016-12-03 21:43:04 UTC (rev 209305)
@@ -1,9 +0,0 @@
-Tests that CSS parser warnings from inline style tags and external stylesheets are sent to the console with correct line and column information.
-{"source":"css","level":"warning","text":"Invalid CSS property declaration at: *","location":"css-source-locations.html:7:20"}
-{"source":"css","level":"warning","text":"Invalid CSS property declaration at: *","location":"css-source-locations.html:8:14"}
-{"source":"css","level":"warning","text":"Invalid CSS property declaration at: *","location":"css-source-locations.html:9:7"}
-{"source":"css","level":"warning","text":"Invalid CSS property declaration at: *","location":"css-source-locations.html:11:8"}
-{"source":"css","level":"warning","text":"Invalid CSS property declaration at: *","location":"errors.css:1:7"}
-{"source":"css","level":"warning","text":"Invalid CSS property declaration at: *","location":"errors.css:1:29"}
-{"source":"css","level":"warning","text":"Invalid CSS property declaration at: *","location":"errors.css:4:5"}
-
Deleted: trunk/LayoutTests/inspector/console/css-source-locations.html (209304 => 209305)
--- trunk/LayoutTests/inspector/console/css-source-locations.html 2016-12-03 21:22:49 UTC (rev 209304)
+++ trunk/LayoutTests/inspector/console/css-source-locations.html 2016-12-03 21:43:04 UTC (rev 209305)
@@ -1,56 +0,0 @@
-<!doctype html>
-<html>
-<head>
-<script src=""
-<script src=""
-<link rel="stylesheet" href=""
- <style> div { * color: red; }</style>
-<style>div { * color: red; }
-div { * color: red; }
- div {
- *
- color:
- red;
- }
-</style>
-<script>
-function test()
-{
- var consoleMessageCount = 0;
- const expectedConsoleMessageCount = 7;
-
- // Due to the difficulty of testing inline style tags in a test case, this test
- // is a reference test that contains serialized Console.messageAdded event data.
- InspectorProtocol.addEventListener({
- event: "Console.messageAdded",
- listener: function(messageObject) {
- var message = ProtocolTest.Console.sanitizeConsoleMessage(messageObject);
- ProtocolTest.log(JSON.stringify(message));
-
- if (++consoleMessageCount !== expectedConsoleMessageCount)
- return;
-
- InspectorProtocol.awaitCommand({
- method: "Console.disable",
- params: {}
- })
- .then(function() {
- ProtocolTest.completeTest();
- });
- }
- });
-
- // Start the test.
- InspectorProtocol.sendCommand({
- method: "Console.enable",
- params: {}
- });
-}
-</script>
-</head>
-<body _onload_="runTest()">
-<p>
-Tests that CSS parser warnings from inline style tags and external stylesheets are sent to the console with correct line and column information.<br>
-</p>
-</body>
-</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
