Title: [209413] trunk/Source/WTF
Revision
209413
Author
msab...@apple.com
Date
2016-12-06 13:03:43 -0800 (Tue, 06 Dec 2016)

Log Message

REGRESSION(r209399): Causes crashes when dumping JIT disassembly
https://bugs.webkit.org/show_bug.cgi?id=165483

Reviewed by Geoffrey Garen.

Fixed the RELEASE_ASSERT() to check that the 6 character string is terminated by a null
character.

* wtf/SixCharacterHash.cpp:
(WTF::sixCharacterHashStringToInteger):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (209412 => 209413)


--- trunk/Source/WTF/ChangeLog	2016-12-06 20:33:49 UTC (rev 209412)
+++ trunk/Source/WTF/ChangeLog	2016-12-06 21:03:43 UTC (rev 209413)
@@ -1,3 +1,16 @@
+2016-12-06  Michael Saboff  <msab...@apple.com>
+
+        REGRESSION(r209399): Causes crashes when dumping JIT disassembly
+        https://bugs.webkit.org/show_bug.cgi?id=165483
+
+        Reviewed by Geoffrey Garen.
+
+        Fixed the RELEASE_ASSERT() to check that the 6 character string is terminated by a null
+        character.
+
+        * wtf/SixCharacterHash.cpp:
+        (WTF::sixCharacterHashStringToInteger):
+
 2016-12-04  Darin Adler  <da...@apple.com>
 
         Use ASCIICType more, and improve it a little bit

Modified: trunk/Source/WTF/wtf/SixCharacterHash.cpp (209412 => 209413)


--- trunk/Source/WTF/wtf/SixCharacterHash.cpp	2016-12-06 20:33:49 UTC (rev 209412)
+++ trunk/Source/WTF/wtf/SixCharacterHash.cpp	2016-12-06 21:03:43 UTC (rev 209413)
@@ -50,7 +50,7 @@
         hash += c - '0' + 26 * 2;
     }
 
-    RELEASE_ASSERT(string[6]); // FIXME: Why does this need to be a RELEASE_ASSERT?
+    RELEASE_ASSERT(!string[6]); // FIXME: Why does this need to be a RELEASE_ASSERT?
 
     return hash;
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to