Title: [209426] trunk/Source/WebCore
Revision
209426
Author
rn...@webkit.org
Date
2016-12-06 15:01:56 -0800 (Tue, 06 Dec 2016)

Log Message

Add more assertions to ElementQueue diagnose a bug
https://bugs.webkit.org/show_bug.cgi?id=164814

Reviewed by Alexey Proskuryakov.

Set m_invoking in release builds now that assertions are also run in release builds.

* dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionStack::ElementQueue::invokeAll):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209425 => 209426)


--- trunk/Source/WebCore/ChangeLog	2016-12-06 22:48:17 UTC (rev 209425)
+++ trunk/Source/WebCore/ChangeLog	2016-12-06 23:01:56 UTC (rev 209426)
@@ -1,3 +1,15 @@
+2016-12-06  Ryosuke Niwa  <rn...@webkit.org>
+
+        Add more assertions to ElementQueue diagnose a bug
+        https://bugs.webkit.org/show_bug.cgi?id=164814
+
+        Reviewed by Alexey Proskuryakov.
+
+        Set m_invoking in release builds now that assertions are also run in release builds.
+
+        * dom/CustomElementReactionQueue.cpp:
+        (WebCore::CustomElementReactionStack::ElementQueue::invokeAll):
+
 2016-12-06  Jer Noble  <jer.no...@apple.com>
 
         YouTube sometimes pauses when switching tabs

Modified: trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp (209425 => 209426)


--- trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp	2016-12-06 22:48:17 UTC (rev 209425)
+++ trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp	2016-12-06 23:01:56 UTC (rev 209426)
@@ -213,10 +213,8 @@
 
 inline void CustomElementReactionStack::ElementQueue::invokeAll()
 {
-#if !ASSERT_DISABLED
     RELEASE_ASSERT(!m_invoking);
     SetForScope<bool> invoking(m_invoking, true);
-#endif
     Vector<Ref<Element>> elements;
     elements.swap(m_elements);
     RELEASE_ASSERT(m_elements.isEmpty());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to