Title: [209502] trunk/Source/WebInspectorUI
- Revision
- 209502
- Author
- nvasil...@apple.com
- Date
- 2016-12-07 17:08:48 -0800 (Wed, 07 Dec 2016)
Log Message
Web Inspector: Control Flow Profiler's event handlers aren't getting removed when ContentView closes
https://bugs.webkit.org/show_bug.cgi?id=165556
Reviewed by Joseph Pecoraro.
* UserInterface/Views/ScriptContentView.js:
(WebInspector.ScriptContentView.prototype.closed):
* UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView.prototype.closed):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (209501 => 209502)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-12-08 01:07:04 UTC (rev 209501)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-12-08 01:08:48 UTC (rev 209502)
@@ -1,3 +1,15 @@
+2016-12-07 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Control Flow Profiler's event handlers aren't getting removed when ContentView closes
+ https://bugs.webkit.org/show_bug.cgi?id=165556
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ScriptContentView.js:
+ (WebInspector.ScriptContentView.prototype.closed):
+ * UserInterface/Views/TextResourceContentView.js:
+ (WebInspector.TextResourceContentView.prototype.closed):
+
2016-12-07 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Add ability to distinguish if a Script was parsed as a module
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js (209501 => 209502)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js 2016-12-08 01:07:04 UTC (rev 209501)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js 2016-12-08 01:08:48 UTC (rev 209502)
@@ -124,6 +124,7 @@
super.closed();
WebInspector.showJavaScriptTypeInformationSetting.removeEventListener(null, null, this);
+ WebInspector.enableControlFlowProfilerSetting.removeEventListener(null, null, this);
this._textEditor.close();
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js (209501 => 209502)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js 2016-12-08 01:07:04 UTC (rev 209501)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js 2016-12-08 01:08:48 UTC (rev 209502)
@@ -121,6 +121,7 @@
this.resource.removeEventListener(null, null, this);
WebInspector.probeManager.removeEventListener(null, null, this);
WebInspector.showJavaScriptTypeInformationSetting.removeEventListener(null, null, this);
+ WebInspector.enableControlFlowProfilerSetting.removeEventListener(null, null, this);
this._textEditor.close();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
