[webkit-changes] [209515] trunk/LayoutTests

Wed, 07 Dec 2016 19:22:52 -0800

Title: [209515] trunk/LayoutTests
Revision
209515
Author
hy...@apple.com
Date
2016-12-07 19:22:36 -0800 (Wed, 07 Dec 2016)

Log Message

[CSS Parser] Unskip media tests
https://bugs.webkit.org/show_bug.cgi?id=165580

Reviewed by Jon Lee.

The new parser will still create rules for hover/pointer queries with
unknown identifiers. Patch the tests to account for this.

* TestExpectations:
* fast/media/mq-any-hover-invalid-expected.txt:
* fast/media/mq-any-hover-invalid.html:
* fast/media/mq-any-pointer-invalid-expected.txt:
* fast/media/mq-any-pointer-invalid.html:
* fast/media/mq-hover-invalid-expected.txt:
* fast/media/mq-hover-invalid.html:
* fast/media/mq-pointer-invalid-expected.txt:
* fast/media/mq-pointer-invalid.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (209514 => 209515)


--- trunk/LayoutTests/ChangeLog	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/ChangeLog	2016-12-08 03:22:36 UTC (rev 209515)
@@ -1,3 +1,23 @@
+2016-12-07  Dave Hyatt  <hy...@apple.com>
+
+        [CSS Parser] Unskip media tests
+        https://bugs.webkit.org/show_bug.cgi?id=165580
+
+        Reviewed by Jon Lee.
+
+        The new parser will still create rules for hover/pointer queries with
+        unknown identifiers. Patch the tests to account for this.
+
+        * TestExpectations:
+        * fast/media/mq-any-hover-invalid-expected.txt:
+        * fast/media/mq-any-hover-invalid.html:
+        * fast/media/mq-any-pointer-invalid-expected.txt:
+        * fast/media/mq-any-pointer-invalid.html:
+        * fast/media/mq-hover-invalid-expected.txt:
+        * fast/media/mq-hover-invalid.html:
+        * fast/media/mq-pointer-invalid-expected.txt:
+        * fast/media/mq-pointer-invalid.html:
+
 2016-12-07  Dean Jackson  <d...@apple.com>
 
         Remove runtime toggle for pointer-lock

Modified: trunk/LayoutTests/TestExpectations (209514 => 209515)


--- trunk/LayoutTests/TestExpectations	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/TestExpectations	2016-12-08 03:22:36 UTC (rev 209515)
@@ -1013,10 +1013,6 @@
 webkit.org/b/165195 fast/css/transform-inline-style.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/uri-token-parsing.html [ Pass Failure ]
 webkit.org/b/165195 fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html [ Pass Failure ]
-webkit.org/b/165195 fast/media/mq-any-hover-invalid.html [ Pass Failure ]
-webkit.org/b/165195 fast/media/mq-any-pointer-invalid.html [ Pass Failure ]
-webkit.org/b/165195 fast/media/mq-hover-invalid.html [ Pass Failure ]
-webkit.org/b/165195 fast/media/mq-pointer-invalid.html [ Pass Failure ]
 webkit.org/b/165195 fast/regions/region-styling/parsing-region-style-rule.html [ Pass Failure ]
 webkit.org/b/165195 fast/selectors/querySelector-pseudo-element.html [ Pass Failure ]
 webkit.org/b/165195 fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html [ Pass Failure ]

Modified: trunk/LayoutTests/fast/media/mq-any-hover-invalid-expected.txt (209514 => 209515)


--- trunk/LayoutTests/fast/media/mq-any-hover-invalid-expected.txt	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/fast/media/mq-any-hover-invalid-expected.txt	2016-12-08 03:22:36 UTC (rev 209515)
@@ -4,19 +4,19 @@
 
 
 PASS window.matchMedia("(any-hover:)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-hover: )").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-hover: WebKit)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-hover: fine)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-hover: portrait)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-hover: \"None\")").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-hover: 'None')").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/media/mq-any-hover-invalid.html (209514 => 209515)


--- trunk/LayoutTests/fast/media/mq-any-hover-invalid.html	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/fast/media/mq-any-hover-invalid.html	2016-12-08 03:22:36 UTC (rev 209515)
@@ -23,7 +23,7 @@
         shouldBeFalse('window.matchMedia("(' + testCase + ')").matches');
 
         targetStyle.innerText = "@media " + testCase + " { }";
-        shouldBe("document.styleSheets[1].cssRules[0].media.length", "0");
+        shouldBe("document.styleSheets[1].cssRules[0].media.length", "1");
     }
 </script>

Modified: trunk/LayoutTests/fast/media/mq-any-pointer-invalid-expected.txt (209514 => 209515)


--- trunk/LayoutTests/fast/media/mq-any-pointer-invalid-expected.txt	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/fast/media/mq-any-pointer-invalid-expected.txt	2016-12-08 03:22:36 UTC (rev 209515)
@@ -4,21 +4,21 @@
 
 
 PASS window.matchMedia("(any-pointer:)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-pointer: )").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-pointer: WebKit)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-pointer: pointer)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-pointer: hover)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-pointer: portrait)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-pointer: \"None\")").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(any-pointer: 'None')").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/media/mq-any-pointer-invalid.html (209514 => 209515)


--- trunk/LayoutTests/fast/media/mq-any-pointer-invalid.html	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/fast/media/mq-any-pointer-invalid.html	2016-12-08 03:22:36 UTC (rev 209515)
@@ -24,7 +24,7 @@
         shouldBeFalse('window.matchMedia("(' + testCase + ')").matches');
 
         targetStyle.innerText = "@media " + testCase + " { }";
-        shouldBe("document.styleSheets[1].cssRules[0].media.length", "0");
+        shouldBe("document.styleSheets[1].cssRules[0].media.length", "1");
     }
 </script>

Modified: trunk/LayoutTests/fast/media/mq-hover-invalid-expected.txt (209514 => 209515)


--- trunk/LayoutTests/fast/media/mq-hover-invalid-expected.txt	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/fast/media/mq-hover-invalid-expected.txt	2016-12-08 03:22:36 UTC (rev 209515)
@@ -4,19 +4,19 @@
 
 
 PASS window.matchMedia("(hover:)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(hover: )").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(hover: WebKit)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(hover: fine)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(hover: portrait)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(hover: \"None\")").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(hover: 'None')").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/media/mq-hover-invalid.html (209514 => 209515)


--- trunk/LayoutTests/fast/media/mq-hover-invalid.html	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/fast/media/mq-hover-invalid.html	2016-12-08 03:22:36 UTC (rev 209515)
@@ -23,7 +23,7 @@
         shouldBeFalse('window.matchMedia("(' + testCase + ')").matches');
 
         targetStyle.innerText = "@media " + testCase + " { }";
-        shouldBe("document.styleSheets[1].cssRules[0].media.length", "0");
+        shouldBe("document.styleSheets[1].cssRules[0].media.length", "1");
     }
 </script>

Modified: trunk/LayoutTests/fast/media/mq-pointer-invalid-expected.txt (209514 => 209515)


--- trunk/LayoutTests/fast/media/mq-pointer-invalid-expected.txt	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/fast/media/mq-pointer-invalid-expected.txt	2016-12-08 03:22:36 UTC (rev 209515)
@@ -4,21 +4,21 @@
 
 
 PASS window.matchMedia("(pointer:)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(pointer: )").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(pointer: WebKit)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(pointer: pointer)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(pointer: hover)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(pointer: portrait)").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(pointer: \"None\")").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS window.matchMedia("(pointer: 'None')").matches is false
-PASS document.styleSheets[1].cssRules[0].media.length is 0
+PASS document.styleSheets[1].cssRules[0].media.length is 1
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/media/mq-pointer-invalid.html (209514 => 209515)


--- trunk/LayoutTests/fast/media/mq-pointer-invalid.html	2016-12-08 02:53:41 UTC (rev 209514)
+++ trunk/LayoutTests/fast/media/mq-pointer-invalid.html	2016-12-08 03:22:36 UTC (rev 209515)
@@ -24,7 +24,7 @@
         shouldBeFalse('window.matchMedia("(' + testCase + ')").matches');
 
         targetStyle.innerText = "@media " + testCase + " { }";
-        shouldBe("document.styleSheets[1].cssRules[0].media.length", "0");
+        shouldBe("document.styleSheets[1].cssRules[0].media.length", "1");
     }
 </script>
 

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to