Title: [209637] trunk/Source/WebKit/mac
Revision
209637
Author
rn...@webkit.org
Date
2016-12-09 16:06:10 -0800 (Fri, 09 Dec 2016)

Log Message

Don’t expose pointer lock in WebKit1 Objective-C API
https://bugs.webkit.org/show_bug.cgi?id=165692

Reviewed by Simon Fraser.

* DOM/DOMDocument.mm:
(-[DOMDocument pointerLockElement]): Deleted.
(-[DOMDocument exitPointerLock]): Deleted.
* DOM/DOMElement.mm:
(-[DOMElement requestPointerLock]): Deleted.
* DOM/DOMMouseEvent.mm:
(-[DOMMouseEvent movementX]): Deleted.
(-[DOMMouseEvent movementY]): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (209636 => 209637)


--- trunk/Source/WebKit/mac/ChangeLog	2016-12-09 23:37:00 UTC (rev 209636)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-12-10 00:06:10 UTC (rev 209637)
@@ -1,5 +1,21 @@
 2016-12-09  Ryosuke Niwa  <rn...@webkit.org>
 
+        Don’t expose pointer lock in WebKit1 Objective-C API
+        https://bugs.webkit.org/show_bug.cgi?id=165692
+
+        Reviewed by Simon Fraser.
+
+        * DOM/DOMDocument.mm:
+        (-[DOMDocument pointerLockElement]): Deleted.
+        (-[DOMDocument exitPointerLock]): Deleted.
+        * DOM/DOMElement.mm:
+        (-[DOMElement requestPointerLock]): Deleted.
+        * DOM/DOMMouseEvent.mm:
+        (-[DOMMouseEvent movementX]): Deleted.
+        (-[DOMMouseEvent movementY]): Deleted.
+
+2016-12-09  Ryosuke Niwa  <rn...@webkit.org>
+
         document.webkitFullscreenElement leaks elements inside a shadow tree
         https://bugs.webkit.org/show_bug.cgi?id=158471
 

Modified: trunk/Source/WebKit/mac/DOM/DOMDocument.mm (209636 => 209637)


--- trunk/Source/WebKit/mac/DOM/DOMDocument.mm	2016-12-09 23:37:00 UTC (rev 209636)
+++ trunk/Source/WebKit/mac/DOM/DOMDocument.mm	2016-12-10 00:06:10 UTC (rev 209637)
@@ -378,16 +378,6 @@
 
 #endif
 
-#if ENABLE(POINTER_LOCK)
-
-- (DOMElement *)pointerLockElement
-{
-    WebCore::JSMainThreadNullState state;
-    return kit(WTF::getPtr(IMPL->pointerLockElement()));
-}
-
-#endif
-
 - (NSString *)visibilityState
 {
     WebCore::JSMainThreadNullState state;
@@ -725,16 +715,6 @@
 
 #endif
 
-#if ENABLE(POINTER_LOCK)
-
-- (void)exitPointerLock
-{
-    WebCore::JSMainThreadNullState state;
-    IMPL->exitPointerLock();
-}
-
-#endif
-
 - (DOMElement *)getElementById:(NSString *)elementId
 {
     WebCore::JSMainThreadNullState state;

Modified: trunk/Source/WebKit/mac/DOM/DOMElement.mm (209636 => 209637)


--- trunk/Source/WebKit/mac/DOM/DOMElement.mm	2016-12-09 23:37:00 UTC (rev 209636)
+++ trunk/Source/WebKit/mac/DOM/DOMElement.mm	2016-12-10 00:06:10 UTC (rev 209637)
@@ -453,16 +453,6 @@
 
 #endif
 
-#if ENABLE(POINTER_LOCK)
-
-- (void)requestPointerLock
-{
-    JSMainThreadNullState state;
-    unwrap(*self).requestPointerLock();
-}
-
-#endif
-
 - (void)remove
 {
     JSMainThreadNullState state;

Modified: trunk/Source/WebKit/mac/DOM/DOMMouseEvent.mm (209636 => 209637)


--- trunk/Source/WebKit/mac/DOM/DOMMouseEvent.mm	2016-12-09 23:37:00 UTC (rev 209636)
+++ trunk/Source/WebKit/mac/DOM/DOMMouseEvent.mm	2016-12-10 00:06:10 UTC (rev 209637)
@@ -104,22 +104,6 @@
     return kit(WTF::getPtr(IMPL->relatedTarget()));
 }
 
-#if ENABLE(POINTER_LOCK)
-- (int)movementX
-{
-    WebCore::JSMainThreadNullState state;
-    return IMPL->movementX();
-}
-#endif
-
-#if ENABLE(POINTER_LOCK)
-- (int)movementY
-{
-    WebCore::JSMainThreadNullState state;
-    return IMPL->movementY();
-}
-#endif
-
 - (int)offsetX
 {
     WebCore::JSMainThreadNullState state;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to