Title: [209776] trunk/Source/WebCore
- Revision
- 209776
- Author
- achristen...@apple.com
- Date
- 2016-12-13 14:11:19 -0800 (Tue, 13 Dec 2016)
Log Message
Restore NSURLRequest's default time interval to match behavior before NSURLSession adoption
https://bugs.webkit.org/show_bug.cgi?id=165821
<rdar://problem/28492939>
Reviewed by Brady Eidson.
Before adopting NSURLSession, iOS used CFURLConnection, not NSURLConnection.
iOS used to have a default timeout of INT_MAX and it now has a default timeout of 0, which means use the
default NSURLRequest timeout, which is 60 seconds. This is not enough for some slow mobile networks,
so we want to match behavior of our CFURLConnection code here.
* platform/network/ResourceRequestBase.cpp:
Use INT_MAX as the default timeout of requests on iOS.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209775 => 209776)
--- trunk/Source/WebCore/ChangeLog 2016-12-13 22:08:49 UTC (rev 209775)
+++ trunk/Source/WebCore/ChangeLog 2016-12-13 22:11:19 UTC (rev 209776)
@@ -1,3 +1,19 @@
+2016-12-13 Alex Christensen <achristen...@webkit.org>
+
+ Restore NSURLRequest's default time interval to match behavior before NSURLSession adoption
+ https://bugs.webkit.org/show_bug.cgi?id=165821
+ <rdar://problem/28492939>
+
+ Reviewed by Brady Eidson.
+
+ Before adopting NSURLSession, iOS used CFURLConnection, not NSURLConnection.
+ iOS used to have a default timeout of INT_MAX and it now has a default timeout of 0, which means use the
+ default NSURLRequest timeout, which is 60 seconds. This is not enough for some slow mobile networks,
+ so we want to match behavior of our CFURLConnection code here.
+
+ * platform/network/ResourceRequestBase.cpp:
+ Use INT_MAX as the default timeout of requests on iOS.
+
2016-12-13 Filip Pizlo <fpi...@apple.com>
Make opaque root scanning truly constraint-based
Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp (209775 => 209776)
--- trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp 2016-12-13 22:08:49 UTC (rev 209775)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp 2016-12-13 22:11:19 UTC (rev 209776)
@@ -32,7 +32,7 @@
namespace WebCore {
-#if !USE(SOUP) && (!PLATFORM(COCOA) || USE(CFURLCONNECTION))
+#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION))
double ResourceRequestBase::s_defaultTimeoutInterval = INT_MAX;
#else
// Will use NSURLRequest default timeout unless set to a non-zero value with setDefaultTimeoutInterval().
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
