Title: [209946] trunk/Source/WebCore
- Revision
- 209946
- Author
- achristen...@apple.com
- Date
- 2016-12-16 15:24:06 -0800 (Fri, 16 Dec 2016)
Log Message
Use initEvent quirk added in r207908 for Flipboard
https://bugs.webkit.org/show_bug.cgi?id=165974
<rdar://problem/28264190>
Reviewed by Chris Dumez.
* dom/Event.cpp:
(WebCore::Event::initEventForBindings):
* platform/RuntimeApplicationChecks.h:
* platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isFlipboard):
Flipboard also has _javascript_ content that calls initEvent with not enough arguments.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209945 => 209946)
--- trunk/Source/WebCore/ChangeLog 2016-12-16 23:17:42 UTC (rev 209945)
+++ trunk/Source/WebCore/ChangeLog 2016-12-16 23:24:06 UTC (rev 209946)
@@ -1,3 +1,18 @@
+2016-12-16 Alex Christensen <achristen...@webkit.org>
+
+ Use initEvent quirk added in r207908 for Flipboard
+ https://bugs.webkit.org/show_bug.cgi?id=165974
+ <rdar://problem/28264190>
+
+ Reviewed by Chris Dumez.
+
+ * dom/Event.cpp:
+ (WebCore::Event::initEventForBindings):
+ * platform/RuntimeApplicationChecks.h:
+ * platform/RuntimeApplicationChecks.mm:
+ (WebCore::IOSApplication::isFlipboard):
+ Flipboard also has _javascript_ content that calls initEvent with not enough arguments.
+
2016-12-16 Chris Dumez <cdu...@apple.com>
[iOS] Align HTML from validation popover style with Copy/Paste callout bar
Modified: trunk/Source/WebCore/dom/Event.cpp (209945 => 209946)
--- trunk/Source/WebCore/dom/Event.cpp 2016-12-16 23:17:42 UTC (rev 209945)
+++ trunk/Source/WebCore/dom/Event.cpp 2016-12-16 23:24:06 UTC (rev 209946)
@@ -94,7 +94,8 @@
{
#if PLATFORM(IOS)
// FIXME: Temporary quirk for Baidu Nuomi App which calls initEvent() with too few parameters (rdar://problem/28707838).
- if (IOSApplication::isBaiduNuomi()) {
+ // FIXME: Quirk also needed for Flipboard for same reason (rdar://problem/28264190).
+ if (IOSApplication::isBaiduNuomi() || IOSApplication::isFlipboard()) {
scriptExecutionContext.addConsoleMessage(MessageSource::JS, MessageLevel::Warning, ASCIILiteral("Calling Event.prototype.initEvent() with less than 3 parameters is deprecated."));
initEvent(type, bubbles, false);
return { };
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (209945 => 209946)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2016-12-16 23:17:42 UTC (rev 209945)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2016-12-16 23:24:06 UTC (rev 209946)
@@ -77,6 +77,7 @@
bool isIBooks();
WEBCORE_EXPORT bool isTheSecretSocietyHiddenMystery();
bool isBaiduNuomi();
+bool isFlipboard();
} // IOSApplication
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm (209945 => 209946)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm 2016-12-16 23:17:42 UTC (rev 209945)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm 2016-12-16 23:24:06 UTC (rev 209946)
@@ -259,6 +259,12 @@
return isBaiduNuomi;
}
+bool IOSApplication::isFlipboard()
+{
+ static bool isFlipboard = applicationBundleIsEqualTo("com.flipboard.flipboard-ipad");
+ return isFlipboard;
+}
+
#endif
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
