Title: [209963] trunk/Source/_javascript_Core
- Revision
- 209963
- Author
- sbar...@apple.com
- Date
- 2016-12-17 09:14:03 -0800 (Sat, 17 Dec 2016)
Log Message
WebAssembly: Change a RELEASE_ASSERT_NOT_REACHED to a jit.breakpoint() for now to allow us to run some wasm benchmarks
https://bugs.webkit.org/show_bug.cgi?id=165990
Reviewed by Mark Lam.
* wasm/WasmBinding.cpp:
(JSC::Wasm::importStubGenerator):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (209962 => 209963)
--- trunk/Source/_javascript_Core/ChangeLog 2016-12-17 16:42:03 UTC (rev 209962)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-12-17 17:14:03 UTC (rev 209963)
@@ -1,3 +1,13 @@
+2016-12-17 Saam Barati <sbar...@apple.com>
+
+ WebAssembly: Change a RELEASE_ASSERT_NOT_REACHED to a jit.breakpoint() for now to allow us to run some wasm benchmarks
+ https://bugs.webkit.org/show_bug.cgi?id=165990
+
+ Reviewed by Mark Lam.
+
+ * wasm/WasmBinding.cpp:
+ (JSC::Wasm::importStubGenerator):
+
2016-12-16 Joseph Pecoraro <pecor...@apple.com>
JSContext Inspector: Avoid some possible exceptions inspecting a JSContext
Modified: trunk/Source/_javascript_Core/wasm/WasmBinding.cpp (209962 => 209963)
--- trunk/Source/_javascript_Core/wasm/WasmBinding.cpp 2016-12-17 16:42:03 UTC (rev 209962)
+++ trunk/Source/_javascript_Core/wasm/WasmBinding.cpp 2016-12-17 17:14:03 UTC (rev 209963)
@@ -78,8 +78,9 @@
case Func:
case Anyfunc:
case I64:
- // For the _javascript_ embedding, imports with these types in their signature arguments are a WebAssembly.Module validation error.
- RELEASE_ASSERT_NOT_REACHED();
+ // FIXME: Figure out the correct behavior here. I suspect we want such a stub to throw an exception immediately
+ // if called. https://bugs.webkit.org/show_bug.cgi?id=165991
+ jit.breakpoint();
break;
case I32: {
GPRReg gprReg;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
