Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (210015 => 210016)
--- trunk/Source/_javascript_Core/ChangeLog 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
@@ -1,3 +1,12 @@
+2016-12-19 Yusuke Suzuki <utatane....@gmail.com>
+
+ [ES6] Enable ES6 Modules
+ https://bugs.webkit.org/show_bug.cgi?id=165849
+
+ Reviewed by Geoffrey Garen.
+
+ * features.json:
+
2016-12-19 Mark Lam <mark....@apple.com>
Rolling out r209974 and r209952. They break some websites in mysterious ways. Step 2: Rollout r209952.
Modified: trunk/Source/_javascript_Core/features.json (210015 => 210016)
--- trunk/Source/_javascript_Core/features.json 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/_javascript_Core/features.json 2016-12-20 08:32:52 UTC (rev 210016)
@@ -193,7 +193,7 @@
{
"name": "Modules",
"status": {
- "status": "In Development",
+ "status": "Done",
"enabled-by-default": true
},
"url": "http://www.ecma-international.org/ecma-262/6.0/index.html#sec-modules",
Modified: trunk/Source/WebCore/ChangeLog (210015 => 210016)
--- trunk/Source/WebCore/ChangeLog 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebCore/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
@@ -1,3 +1,16 @@
+2016-12-19 Yusuke Suzuki <utatane....@gmail.com>
+
+ [ES6] Enable ES6 Modules
+ https://bugs.webkit.org/show_bug.cgi?id=165849
+
+ Reviewed by Geoffrey Garen.
+
+ * dom/ScriptElement.cpp:
+ (WebCore::ScriptElement::determineScriptType):
+ * html/parser/HTMLPreloadScanner.cpp:
+ (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
+ * page/Settings.in:
+
2016-12-17 Sam Weinig <s...@webkit.org>
Remove a few trivial custom bindings
Added: trunk/Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp (0 => 210016)
--- trunk/Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp (rev 0)
+++ trunk/Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -0,0 +1,64 @@
+/*
+ * Copyright (C) 2016 Yusuke Suzuki <utatane....@gmail.com>.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "CryptoAlgorithmRSASSA_PKCS1_v1_5.h"
+
+#if ENABLE(SUBTLE_CRYPTO)
+
+#include "CryptoAlgorithmRsaSsaParamsDeprecated.h"
+#include "CryptoKeyRSA.h"
+#include "ExceptionCode.h"
+#include "NotImplemented.h"
+#include <gcrypt.h>
+#include <wtf/CryptographicUtilities.h>
+
+namespace WebCore {
+
+void CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign(Ref<CryptoKey>&&, Vector<uint8_t>&&, VectorCallback&&, ExceptionCallback&&, ScriptExecutionContext&, WorkQueue&)
+{
+ notImplemented();
+}
+
+void CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify(Ref<CryptoKey>&&, Vector<uint8_t>&&, Vector<uint8_t>&&, BoolCallback&&, ExceptionCallback&&, ScriptExecutionContext&, WorkQueue&)
+{
+ notImplemented();
+}
+
+ExceptionOr<void> CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign(const CryptoAlgorithmRsaSsaParamsDeprecated&, const CryptoKeyRSA&, const CryptoOperationData&, VectorCallback&&, VoidCallback&&)
+{
+ notImplemented();
+ return Exception { NOT_SUPPORTED_ERR };
+}
+
+ExceptionOr<void> CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify(const CryptoAlgorithmRsaSsaParamsDeprecated&, const CryptoKeyRSA&, const CryptoOperationData&, const CryptoOperationData&, BoolCallback&&, VoidCallback&&)
+{
+ notImplemented();
+ return Exception { NOT_SUPPORTED_ERR };
+}
+
+} // namespace WebCore
+
+#endif // ENABLE(SUBTLE_CRYPTO)
Modified: trunk/Source/WebCore/dom/ScriptElement.cpp (210015 => 210016)
--- trunk/Source/WebCore/dom/ScriptElement.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebCore/dom/ScriptElement.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -170,9 +170,6 @@
if (!m_element.document().isHTMLDocument())
return std::nullopt;
- auto* settings = m_element.document().settings();
- if (!settings || !settings->es6ModulesEnabled())
- return std::nullopt;
// https://html.spec.whatwg.org/multipage/scripting.html#attr-script-type
// Setting the attribute to an ASCII case-insensitive match for the string "module" means that the script is a module script.
if (equalLettersIgnoringASCIICase(type, "module"))
Modified: trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp (210015 => 210016)
--- trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -212,11 +212,8 @@
break;
case TagId::Script:
if (match(attributeName, typeAttr)) {
- auto* settings = document.settings();
- if (settings && settings->es6ModulesEnabled()) {
- m_moduleScript = equalLettersIgnoringASCIICase(attributeValue, "module") ? PreloadRequest::ModuleScript::Yes : PreloadRequest::ModuleScript::No;
- break;
- }
+ m_moduleScript = equalLettersIgnoringASCIICase(attributeValue, "module") ? PreloadRequest::ModuleScript::Yes : PreloadRequest::ModuleScript::No;
+ break;
} else if (match(attributeName, nonceAttr))
m_nonceAttribute = attributeValue;
processImageAndScriptAttribute(attributeName, attributeValue);
Modified: trunk/Source/WebCore/page/Settings.in (210015 => 210016)
--- trunk/Source/WebCore/page/Settings.in 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebCore/page/Settings.in 2016-12-20 08:32:52 UTC (rev 210016)
@@ -291,6 +291,4 @@
largeImageAsyncDecodingEnabled initial=true
animatedImageAsyncDecodingEnabled initial=true
-es6ModulesEnabled initial=false
-
shouldSuppressKeyboardInputDuringProvisionalNavigation initial=false
Modified: trunk/Source/WebKit/mac/ChangeLog (210015 => 210016)
--- trunk/Source/WebKit/mac/ChangeLog 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
@@ -1,3 +1,19 @@
+2016-12-19 Yusuke Suzuki <utatane....@gmail.com>
+
+ [ES6] Enable ES6 Modules
+ https://bugs.webkit.org/show_bug.cgi?id=165849
+
+ Reviewed by Geoffrey Garen.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences es6ModulesEnabled]): Deleted.
+ (-[WebPreferences setES6ModulesEnabled:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2016-12-16 Dave Hyatt <hy...@apple.com>
[CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (210015 => 210016)
--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-12-20 08:32:52 UTC (rev 210016)
@@ -168,7 +168,6 @@
#define WebKitDOMIteratorEnabledPreferenceKey @"WebKitDOMIteratorEnabled"
#define WebKitFetchAPIEnabledPreferenceKey @"WebKitFetchAPIEnabled"
#define WebKitDownloadAttributeEnabledPreferenceKey @"WebKitDownloadAttributeEnabled"
-#define WebKitES6ModulesEnabledPreferenceKey @"WebKitES6ModulesEnabled"
#define WebKitCSSGridLayoutEnabledPreferenceKey @"WebKitCSSGridLayoutEnabled"
#define WebKitVisualViewportEnabledPreferenceKey @"WebKitVisualViewportEnabled"
#define WebKitModernMediaControlsEnabledPreferenceKey @"WebKitModernMediaControlsEnabled"
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (210015 => 210016)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-12-20 08:32:52 UTC (rev 210016)
@@ -621,7 +621,6 @@
#if ENABLE(DOWNLOAD_ATTRIBUTE)
[NSNumber numberWithBool:NO], WebKitDownloadAttributeEnabledPreferenceKey,
#endif
- [NSNumber numberWithBool:NO], WebKitES6ModulesEnabledPreferenceKey,
#if ENABLE(CSS_GRID_LAYOUT)
[NSNumber numberWithBool:YES], WebKitCSSGridLayoutEnabledPreferenceKey,
#endif
@@ -2848,16 +2847,6 @@
[self _setBoolValue:flag forKey:WebKitDownloadAttributeEnabledPreferenceKey];
}
-- (BOOL)es6ModulesEnabled
-{
- return [self _boolValueForKey:WebKitES6ModulesEnabledPreferenceKey];
-}
-
-- (void)setES6ModulesEnabled:(BOOL)flag
-{
- [self _setBoolValue:flag forKey:WebKitES6ModulesEnabledPreferenceKey];
-}
-
- (BOOL)isCSSGridLayoutEnabled
{
return [self _boolValueForKey:WebKitCSSGridLayoutEnabledPreferenceKey];
Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (210015 => 210016)
--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-12-20 08:32:52 UTC (rev 210016)
@@ -505,9 +505,6 @@
- (void)setDownloadAttributeEnabled:(BOOL)flag;
- (BOOL)downloadAttributeEnabled;
-- (void)setES6ModulesEnabled:(BOOL)flag;
-- (BOOL)es6ModulesEnabled;
-
- (void)setCSSGridLayoutEnabled:(BOOL)flag;
- (BOOL)isCSSGridLayoutEnabled;
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (210015 => 210016)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-12-20 08:32:52 UTC (rev 210016)
@@ -2859,8 +2859,6 @@
RuntimeEnabledFeatures::sharedFeatures().setDownloadAttributeEnabled([preferences downloadAttributeEnabled]);
#endif
- settings.setEs6ModulesEnabled([preferences es6ModulesEnabled]);
-
#if ENABLE(CSS_GRID_LAYOUT)
RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled([preferences isCSSGridLayoutEnabled]);
#endif
Modified: trunk/Source/WebKit/win/ChangeLog (210015 => 210016)
--- trunk/Source/WebKit/win/ChangeLog 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
@@ -1,3 +1,19 @@
+2016-12-19 Yusuke Suzuki <utatane....@gmail.com>
+
+ [ES6] Enable ES6 Modules
+ https://bugs.webkit.org/show_bug.cgi?id=165849
+
+ Reviewed by Geoffrey Garen.
+
+ * Interfaces/IWebPreferencesPrivate.idl:
+ * WebPreferenceKeysPrivate.h:
+ * WebPreferences.cpp:
+ (WebPreferences::setES6ModulesEnabled): Deleted.
+ (WebPreferences::es6ModulesEnabled): Deleted.
+ * WebPreferences.h:
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
2016-12-10 Filip Pizlo <fpi...@apple.com>
The DOM should have an advancing wavefront opaque root barrier
Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (210015 => 210016)
--- trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2016-12-20 08:32:52 UTC (rev 210016)
@@ -185,8 +185,6 @@
HRESULT setCustomElementsEnabled([in] BOOL enabled);
HRESULT modernMediaControlsEnabled([out, retval] BOOL* enabled);
HRESULT setModernMediaControlsEnabled([in] BOOL enabled);
- HRESULT es6ModulesEnabled([out, retval] BOOL* enabled);
- HRESULT setES6ModulesEnabled([in] BOOL enabled);
}
[uuid(F9582D72-6348-45B1-AB09-39E33459B5B9)]
Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (210015 => 210016)
--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2016-12-20 08:32:52 UTC (rev 210016)
@@ -177,5 +177,3 @@
#define WebKitCustomElementsEnabledPreferenceKey "WebKitCustomElementsEnabled"
#define WebKitModernMediaControlsEnabledPreferenceKey "WebKitModernMediaControlsEnabled"
-
-#define WebKitES6ModulesEnabledPreferenceKey "WebKitES6ModulesEnabled"
Modified: trunk/Source/WebKit/win/WebPreferences.cpp (210015 => 210016)
--- trunk/Source/WebKit/win/WebPreferences.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/WebPreferences.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -2003,20 +2003,6 @@
return S_OK;
}
-HRESULT WebPreferences::setES6ModulesEnabled(BOOL enabled)
-{
- setBoolValue(WebKitES6ModulesEnabledPreferenceKey, enabled);
- return S_OK;
-}
-
-HRESULT WebPreferences::es6ModulesEnabled(_Out_ BOOL* enabled)
-{
- if (!enabled)
- return E_POINTER;
- *enabled = boolValueForKey(WebKitES6ModulesEnabledPreferenceKey);
- return S_OK;
-}
-
HRESULT WebPreferences::setApplicationId(BSTR applicationId)
{
m_applicationId = String(applicationId).createCFString();
Modified: trunk/Source/WebKit/win/WebPreferences.h (210015 => 210016)
--- trunk/Source/WebKit/win/WebPreferences.h 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/WebPreferences.h 2016-12-20 08:32:52 UTC (rev 210016)
@@ -242,8 +242,6 @@
virtual HRESULT STDMETHODCALLTYPE setCustomElementsEnabled(BOOL);
virtual HRESULT STDMETHODCALLTYPE modernMediaControlsEnabled(_Out_ BOOL*);
virtual HRESULT STDMETHODCALLTYPE setModernMediaControlsEnabled(BOOL);
- virtual HRESULT STDMETHODCALLTYPE es6ModulesEnabled(_Out_ BOOL*);
- virtual HRESULT STDMETHODCALLTYPE setES6ModulesEnabled(BOOL);
// IWebPreferencesPrivate4
virtual HRESULT STDMETHODCALLTYPE setApplicationId(BSTR);
Modified: trunk/Source/WebKit/win/WebView.cpp (210015 => 210016)
--- trunk/Source/WebKit/win/WebView.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/WebView.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -5254,11 +5254,6 @@
return hr;
RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled(!!enabled);
- hr = prefsPrivate->es6ModulesEnabled(&enabled);
- if (FAILED(hr))
- return hr;
- settings.setEs6ModulesEnabled(!!enabled);
-
hr = prefsPrivate->modernMediaControlsEnabled(&enabled);
if (FAILED(hr))
return hr;
Modified: trunk/Source/WebKit2/ChangeLog (210015 => 210016)
--- trunk/Source/WebKit2/ChangeLog 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
@@ -1,3 +1,20 @@
+2016-12-19 Yusuke Suzuki <utatane....@gmail.com>
+
+ [ES6] Enable ES6 Modules
+ https://bugs.webkit.org/show_bug.cgi?id=165849
+
+ Reviewed by Geoffrey Garen.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetES6ModulesEnabled): Deleted.
+ (WKPreferencesGetES6ModulesEnabled): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2016-12-19 Keith Rollin <krol...@apple.com>
Fix unwanted deletion of record/replay files
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (210015 => 210016)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-12-20 08:32:52 UTC (rev 210016)
@@ -321,7 +321,6 @@
macro(InputEventsEnabled, inputEventsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Input Events", "Enable InputEvents support") \
macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "SubtleCrypto", "Enable SubtleCrypto support") \
macro(WebGL2Enabled, webGL2Enabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "WebGL 2.0", "WebGL 2 prototype") \
- macro(ES6ModulesEnabled, es6ModulesEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "ES6 Modules", "Enable ES6 Modules support") \
\
#if PLATFORM(COCOA)
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (210015 => 210016)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -1561,16 +1561,6 @@
return toImpl(preferencesRef)->downloadAttributeEnabled();
}
-void WKPreferencesSetES6ModulesEnabled(WKPreferencesRef preferencesRef, bool flag)
-{
- toImpl(preferencesRef)->setES6ModulesEnabled(flag);
-}
-
-bool WKPreferencesGetES6ModulesEnabled(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->es6ModulesEnabled();
-}
-
void WKPreferencesSetIntersectionObserverEnabled(WKPreferencesRef preferencesRef, bool flag)
{
toImpl(preferencesRef)->setIntersectionObserverEnabled(flag);
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (210015 => 210016)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-12-20 08:32:52 UTC (rev 210016)
@@ -442,10 +442,6 @@
WK_EXPORT bool WKPreferencesGetAllowsPictureInPictureMediaPlayback(WKPreferencesRef);
// Defaults to false
-WK_EXPORT void WKPreferencesSetES6ModulesEnabled(WKPreferencesRef, bool flag);
-WK_EXPORT bool WKPreferencesGetES6ModulesEnabled(WKPreferencesRef);
-
-// Defaults to false
WK_EXPORT void WKPreferencesSetIntersectionObserverEnabled(WKPreferencesRef, bool flag);
WK_EXPORT bool WKPreferencesGetIntersectionObserverEnabled(WKPreferencesRef);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (210015 => 210016)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -259,7 +259,6 @@
macro(WebKitVisualViewportEnabled, VisualViewportEnabled, visualViewportEnabled) \
macro(WebKitLargeImageAsyncDecodingEnabled, LargeImageAsyncDecodingEnabled, largeImageAsyncDecodingEnabled) \
macro(WebKitAnimatedImageAsyncDecodingEnabled, AnimatedImageAsyncDecodingEnabled, animatedImageAsyncDecodingEnabled) \
- macro(WebKitES6ModulesEnabled, Es6ModulesEnabled, es6ModulesEnabled) \
\
#define OVERRIDE_PREFERENCE_AND_SET_IN_EXISTING_PAGES(TestRunnerName, SettingsName, WebPreferencesName) \
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (210015 => 210016)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -3189,8 +3189,6 @@
RuntimeEnabledFeatures::sharedFeatures().setDownloadAttributeEnabled(store.getBoolValueForKey(WebPreferencesKey::downloadAttributeEnabledKey()));
#endif
- settings.setEs6ModulesEnabled(store.getBoolValueForKey(WebPreferencesKey::es6ModulesEnabledKey()));
-
RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(store.getBoolValueForKey(WebPreferencesKey::shadowDOMEnabledKey()));
RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey()));
Modified: trunk/Tools/ChangeLog (210015 => 210016)
--- trunk/Tools/ChangeLog 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
@@ -1,3 +1,20 @@
+2016-12-19 Yusuke Suzuki <utatane....@gmail.com>
+
+ [ES6] Enable ES6 Modules
+ https://bugs.webkit.org/show_bug.cgi?id=165849
+
+ Reviewed by Geoffrey Garen.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (resetWebPreferencesToConsistentValues):
+ * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+ (WTR::InjectedBundle::beginTesting):
+ * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+ (WTR::TestRunner::setES6ModulesEnabled): Deleted.
+ * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
2016-12-19 Ryan Haddad <ryanhad...@apple.com>
Repurpose bots and clean up dashboard.
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (210015 => 210016)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-12-20 08:32:52 UTC (rev 210016)
@@ -992,8 +992,6 @@
[preferences setDownloadAttributeEnabled:YES];
- [preferences setES6ModulesEnabled:YES];
-
[preferences setHiddenPageDOMTimerThrottlingEnabled:NO];
[preferences setHiddenPageCSSAnimationSuspensionEnabled:NO];
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (210015 => 210016)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -853,7 +853,6 @@
prefsPrivate3->setFetchAPIEnabled(TRUE);
prefsPrivate3->setShadowDOMEnabled(TRUE);
prefsPrivate3->setCustomElementsEnabled(TRUE);
- prefsPrivate3->setES6ModulesEnabled(TRUE);
prefsPrivate3->setDOMIteratorEnabled(TRUE);
prefsPrivate3->setModernMediaControlsEnabled(FALSE);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (210015 => 210016)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -330,8 +330,6 @@
m_testRunner->setDownloadAttributeEnabled(true);
- m_testRunner->setES6ModulesEnabled(true);
-
m_testRunner->setEncryptedMediaAPIEnabled(true);
m_testRunner->setCloseRemainingWindowsWhenComplete(false);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (210015 => 210016)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2016-12-20 08:32:52 UTC (rev 210016)
@@ -410,13 +410,6 @@
WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
}
-void TestRunner::setES6ModulesEnabled(bool enabled)
-{
- WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitES6ModulesEnabled"));
- auto& injectedBundle = InjectedBundle::singleton();
- WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
-}
-
void TestRunner::setEncryptedMediaAPIEnabled(bool enabled)
{
WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitEncryptedMediaAPIEnabled"));
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (210015 => 210016)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2016-12-20 08:32:52 UTC (rev 210016)
@@ -129,7 +129,6 @@
void setAsynchronousSpellCheckingEnabled(bool);
void setDownloadAttributeEnabled(bool);
void setAllowsAnySSLCertificate(bool);
- void setES6ModulesEnabled(bool);
void setEncryptedMediaAPIEnabled(bool);
void setSubtleCryptoEnabled(bool);
void setMediaStreamEnabled(bool);
