Title: [210022] trunk/LayoutTests
- Revision
- 210022
- Author
- commit-qu...@webkit.org
- Date
- 2016-12-20 09:25:26 -0800 (Tue, 20 Dec 2016)
Log Message
Fix memory leak in malformed test
https://bugs.webkit.org/show_bug.cgi?id=165917
Patch by Megan Gardner <megan_gard...@apple.com> on 2016-12-20
Reviewed by Alexey Proskuryakov.
Navigation caused 'onload' to be called twice, causing test harness to have extraneous
HID callback around after script controller was dismantled. Loading in body will eliminate
double load, and also prevent other race conditions where the body doesn't load fast enough.
* http/tests/quicklook/hide-referer-on-navigation.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (210021 => 210022)
--- trunk/LayoutTests/ChangeLog 2016-12-20 12:27:51 UTC (rev 210021)
+++ trunk/LayoutTests/ChangeLog 2016-12-20 17:25:26 UTC (rev 210022)
@@ -1,3 +1,16 @@
+2016-12-20 Megan Gardner <megan_gard...@apple.com>
+
+ Fix memory leak in malformed test
+ https://bugs.webkit.org/show_bug.cgi?id=165917
+
+ Reviewed by Alexey Proskuryakov.
+
+ Navigation caused 'onload' to be called twice, causing test harness to have extraneous
+ HID callback around after script controller was dismantled. Loading in body will eliminate
+ double load, and also prevent other race conditions where the body doesn't load fast enough.
+
+ * http/tests/quicklook/hide-referer-on-navigation.html:
+
2016-12-20 Nael Ouedraogo <nael.ouedra...@crf.canon.fr>
WebRTC: RTCPeerConnection constructor argument should be optional
Modified: trunk/LayoutTests/http/tests/quicklook/hide-referer-on-navigation.html (210021 => 210022)
--- trunk/LayoutTests/http/tests/quicklook/hide-referer-on-navigation.html 2016-12-20 12:27:51 UTC (rev 210021)
+++ trunk/LayoutTests/http/tests/quicklook/hide-referer-on-navigation.html 2016-12-20 17:25:26 UTC (rev 210022)
@@ -3,6 +3,10 @@
<head>
<script src=""
<script>
+function doTest(){
+ tapAtPointAndNotifyDone(document.getElementsByTagName('iframe')[0].offsetLeft + 5, document.getElementsByTagName('iframe')[0].offsetTop + 5)
+}
+
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.dumpChildFramesAsText();
@@ -10,8 +14,9 @@
}
</script>
</head>
-<body>
+<body _onload_="doTest()">
<p>This test verifies that the HTTP referrer is hidden when navigating from a Microsoft Word QuickLook preview. This test PASSED only if nothing is printed below.</p>
-<iframe src="" _onload_="tapAtPoint(this.offsetLeft + 5, this.offsetTop + 5, function () { /* Do nothing */ })"></iframe>
+
+<iframe src=""
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
