Title: [210311] trunk/Source/WebInspectorUI
Revision
210311
Author
nvasil...@apple.com
Date
2017-01-04 18:00:28 -0800 (Wed, 04 Jan 2017)

Log Message

Web Inspector: application cache details not shown in Storage Tab
https://bugs.webkit.org/show_bug.cgi?id=166699
<rdar://problem/29871716>

Reviewed by Brian Burg.

Fix a ternary operator precedence. The following _expression_ throws an exception:

    true || false ? i.dont.exist : false

* UserInterface/Views/ApplicationCacheFrameTreeElement.js:
(WebInspector.ApplicationCacheFrameTreeElement.prototype.updateTitles):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (210310 => 210311)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-01-05 01:32:02 UTC (rev 210310)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-01-05 02:00:28 UTC (rev 210311)
@@ -1,3 +1,18 @@
+2017-01-04  Nikita Vasilyev  <nvasil...@apple.com>
+
+        Web Inspector: application cache details not shown in Storage Tab
+        https://bugs.webkit.org/show_bug.cgi?id=166699
+        <rdar://problem/29871716>
+
+        Reviewed by Brian Burg.
+
+        Fix a ternary operator precedence. The following _expression_ throws an exception:
+
+            true || false ? i.dont.exist : false
+
+        * UserInterface/Views/ApplicationCacheFrameTreeElement.js:
+        (WebInspector.ApplicationCacheFrameTreeElement.prototype.updateTitles):
+
 2017-01-03  Brian Burg  <bb...@apple.com>
 
         Web Inspector: WrappedPromise constructor should behave like the Promise constructor

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js (210310 => 210311)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js	2017-01-05 01:32:02 UTC (rev 210310)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js	2017-01-05 02:00:28 UTC (rev 210311)
@@ -56,7 +56,7 @@
             currentAncestor = currentAncestor.parent;
         }
 
-        var subtitleIsDuplicate = subtitle === this._mainTitle || manifestTreeElement ? subtitle === manifestTreeElement.subtitle : false;
+        var subtitleIsDuplicate = subtitle === this._mainTitle || (manifestTreeElement && manifestTreeElement.subtitle === subtitle);
         this.subtitle = subtitleIsDuplicate ? null : subtitle;
     }
 };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to