Title: [210344] branches/safari-603-branch/Tools
- Revision
- 210344
- Author
- matthew_han...@apple.com
- Date
- 2017-01-05 09:09:07 -0800 (Thu, 05 Jan 2017)
Log Message
Merge r210082. rdar://problem/29758428
Modified Paths
Diff
Modified: branches/safari-603-branch/Tools/ChangeLog (210343 => 210344)
--- branches/safari-603-branch/Tools/ChangeLog 2017-01-05 17:09:05 UTC (rev 210343)
+++ branches/safari-603-branch/Tools/ChangeLog 2017-01-05 17:09:07 UTC (rev 210344)
@@ -1,5 +1,23 @@
2017-01-05 Matthew Hanson <matthew_han...@apple.com>
+ Merge r210082. rdar://problem/29758428
+
+ 2016-12-21 Alexey Proskuryakov <a...@apple.com>
+
+ REGRESSION: API test failure: _WKDownload.OriginatingWebView
+ https://bugs.webkit.org/show_bug.cgi?id=166033
+ <rdar://problem/29758428>
+
+ Reviewed by Simon Fraser.
+
+ Add an @autoreleasepool around the code that allocates the WKWebView,
+ so that it can be destroyed by removing the last reference in _downloadDidStart.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
+ (TEST):
+
+2017-01-05 Matthew Hanson <matthew_han...@apple.com>
+
Merge r210050. rdar://problem/29758419
2016-12-20 Simon Fraser <simon.fra...@apple.com>
Modified: branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm (210343 => 210344)
--- branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2017-01-05 17:09:05 UTC (rev 210343)
+++ branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2017-01-05 17:09:07 UTC (rev 210344)
@@ -257,7 +257,7 @@
{
RetainPtr<DownloadNavigationDelegate> navigationDelegate = adoptNS([[DownloadNavigationDelegate alloc] init]);
RetainPtr<OriginatingWebViewDownloadDelegate> downloadDelegate;
- {
+ @autoreleasepool {
RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
[webView setNavigationDelegate:navigationDelegate.get()];
downloadDelegate = adoptNS([[OriginatingWebViewDownloadDelegate alloc] initWithWebView:webView.get()]);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
