Title: [210691] trunk/Source/WebInspectorUI
- Revision
- 210691
- Author
- nvasil...@apple.com
- Date
- 2017-01-12 17:30:02 -0800 (Thu, 12 Jan 2017)
Log Message
REGRESSION (r209711): Web Inspector: in Elements Tab, selecting a deeply nested DOM element causes navigation bar buttons to be pushed off the leading edge
https://bugs.webkit.org/show_bug.cgi?id=166898
<rdar://problem/29951737>
Reviewed by Timothy Hatcher.
* UserInterface/Views/HierarchicalPathComponent.js:
(WebInspector.HierarchicalPathComponent.prototype.set selectorArrows):
The following operations do NOT produce the same result:
classList.toogle(aString, undefined)
classList.toogle(aString, false)
The former is an equivalent of classList.toogle(aString), e.g. it set a class if it wasn't set before.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (210690 => 210691)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-01-13 01:26:49 UTC (rev 210690)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-01-13 01:30:02 UTC (rev 210691)
@@ -1,3 +1,20 @@
+2017-01-12 Nikita Vasilyev <nvasil...@apple.com>
+
+ REGRESSION (r209711): Web Inspector: in Elements Tab, selecting a deeply nested DOM element causes navigation bar buttons to be pushed off the leading edge
+ https://bugs.webkit.org/show_bug.cgi?id=166898
+ <rdar://problem/29951737>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/HierarchicalPathComponent.js:
+ (WebInspector.HierarchicalPathComponent.prototype.set selectorArrows):
+ The following operations do NOT produce the same result:
+
+ classList.toogle(aString, undefined)
+ classList.toogle(aString, false)
+
+ The former is an equivalent of classList.toogle(aString), e.g. it set a class if it wasn't set before.
+
2017-01-12 Devin Rousso <dcrousso+web...@gmail.com>
Web Inspector: cubic-bezier editor behaves poorly for invalid inputs in component fields
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js (210690 => 210691)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js 2017-01-13 01:26:49 UTC (rev 210690)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js 2017-01-13 01:30:02 UTC (rev 210691)
@@ -213,7 +213,7 @@
this._selectorArrowsElement = null;
}
- this._element.classList.toggle("show-selector-arrows", this._selectorArrows);
+ this._element.classList.toggle("show-selector-arrows", !!this._selectorArrows);
}
get previousSibling() { return this._previousSibling; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
