Title: [210760] trunk/Source/WebCore
- Revision
- 210760
- Author
- bfulg...@apple.com
- Date
- 2017-01-13 19:42:32 -0800 (Fri, 13 Jan 2017)
Log Message
Potential nullptr dereference in RenderLayer::updateLayerPosition()
https://bugs.webkit.org/show_bug.cgi?id=167036
<rdar://problem/30023019>
Reviewed by Dean Jackson.
A value was being used without nullptr checking, even though it had been checked for null a
few lines prior.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition): Add missing nullptr check.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (210759 => 210760)
--- trunk/Source/WebCore/ChangeLog 2017-01-14 03:40:52 UTC (rev 210759)
+++ trunk/Source/WebCore/ChangeLog 2017-01-14 03:42:32 UTC (rev 210760)
@@ -1,3 +1,17 @@
+2017-01-13 Brent Fulgham <bfulg...@apple.com>
+
+ Potential nullptr dereference in RenderLayer::updateLayerPosition()
+ https://bugs.webkit.org/show_bug.cgi?id=167036
+ <rdar://problem/30023019>
+
+ Reviewed by Dean Jackson.
+
+ A value was being used without nullptr checking, even though it had been checked for null a
+ few lines prior.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPosition): Add missing nullptr check.
+
2017-01-11 Darin Adler <da...@apple.com>
Remove PassRefPtr from more of "platform"
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (210759 => 210760)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2017-01-14 03:40:52 UTC (rev 210759)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2017-01-14 03:42:32 UTC (rev 210760)
@@ -1360,7 +1360,7 @@
}
ancestor = ancestor->parent();
}
- if (is<RenderBox>(*ancestor) && is<RenderTableRow>(*ancestor)) {
+ if (ancestor && is<RenderBox>(*ancestor) && is<RenderTableRow>(*ancestor)) {
// Put ourselves into the row coordinate space.
localPoint -= downcast<RenderBox>(*ancestor).topLeftLocationOffset();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
