Title: [210855] trunk/Source/WebCore
Revision
210855
Author
pvol...@apple.com
Date
2017-01-18 10:45:59 -0800 (Wed, 18 Jan 2017)

Log Message

Crash when changing video subtitles.
https://bugs.webkit.org/show_bug.cgi?id=167159

Reviewed by Xabier Rodriguez-Calvar.

Add null pointer check.

* html/track/VTTCue.cpp:
(WebCore::VTTCue::removeDisplayTree):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (210854 => 210855)


--- trunk/Source/WebCore/ChangeLog	2017-01-18 18:45:12 UTC (rev 210854)
+++ trunk/Source/WebCore/ChangeLog	2017-01-18 18:45:59 UTC (rev 210855)
@@ -1,3 +1,15 @@
+2017-01-18  Per Arne Vollan  <pvol...@apple.com>
+
+        Crash when changing video subtitles.
+        https://bugs.webkit.org/show_bug.cgi?id=167159
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Add null pointer check.
+
+        * html/track/VTTCue.cpp:
+        (WebCore::VTTCue::removeDisplayTree):
+
 2017-01-18  Youenn Fablet  <you...@apple.com>
 
         [Fetch API] Update content-type in case of form data

Modified: trunk/Source/WebCore/html/track/VTTCue.cpp (210854 => 210855)


--- trunk/Source/WebCore/html/track/VTTCue.cpp	2017-01-18 18:45:12 UTC (rev 210854)
+++ trunk/Source/WebCore/html/track/VTTCue.cpp	2017-01-18 18:45:59 UTC (rev 210855)
@@ -838,7 +838,8 @@
     if (m_notifyRegion && track()) {
         if (VTTRegionList* regions = track()->regions()) {
             if (VTTRegion* region = regions->getRegionById(m_regionId))
-                region->willRemoveTextTrackCueBox(m_displayTree.get());
+                if (hasDisplayTree())
+                    region->willRemoveTextTrackCueBox(m_displayTree.get());
         }
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to