Title: [99023] branches/chromium/912/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
- Revision
- 99023
- Author
- cev...@google.com
- Date
- 2011-11-01 18:32:27 -0700 (Tue, 01 Nov 2011)
Log Message
Merge 98796 - Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145
Reviewed by Ojan Vafai.
Fix a potential crash without tests because we don't have a reduction.
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
TBR=rn...@webkit.org
Review URL: http://codereview.chromium.org/8437036
Modified Paths
Diff
Modified: branches/chromium/912/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (99022 => 99023)
--- branches/chromium/912/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp 2011-11-02 01:23:09 UTC (rev 99022)
+++ branches/chromium/912/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp 2011-11-02 01:32:27 UTC (rev 99023)
@@ -52,7 +52,7 @@
{
ASSERT(nodeToReplace->inDocument());
ExceptionCode ec = 0;
- ContainerNode* parentNode = nodeToReplace->parentNode();
+ RefPtr<ContainerNode> parentNode = nodeToReplace->parentNode();
parentNode->insertBefore(newNode, nodeToReplace, ec);
ASSERT(!ec);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
