Title: [211315] trunk/Tools
- Revision
- 211315
- Author
- keith_mil...@apple.com
- Date
- 2017-01-27 16:55:39 -0800 (Fri, 27 Jan 2017)
Log Message
run-benchmarks should make sure it passes the test url to the right application
https://bugs.webkit.org/show_bug.cgi?id=167533
Reviewed by Joseph Pecoraro.
This fixes an issue when trying to run-benchmark script with the
system default browser set to STP. Previously, it would run
the test in STP rather than the provided build. Now, it should run
in the provided build.
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.launch_url):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (211314 => 211315)
--- trunk/Tools/ChangeLog 2017-01-28 00:49:01 UTC (rev 211314)
+++ trunk/Tools/ChangeLog 2017-01-28 00:55:39 UTC (rev 211315)
@@ -1,3 +1,18 @@
+2017-01-27 Keith Miller <keith_mil...@apple.com>
+
+ run-benchmarks should make sure it passes the test url to the right application
+ https://bugs.webkit.org/show_bug.cgi?id=167533
+
+ Reviewed by Joseph Pecoraro.
+
+ This fixes an issue when trying to run-benchmark script with the
+ system default browser set to STP. Previously, it would run
+ the test in STP rather than the provided build. Now, it should run
+ in the provided build.
+
+ * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
+ (OSXSafariDriver.launch_url):
+
2017-01-27 Myles C. Maxfield <mmaxfi...@apple.com>
[Cocoa] Prepare ComplexTextController for unit testing
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py (211314 => 211315)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py 2017-01-28 00:49:01 UTC (rev 211314)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py 2017-01-28 00:55:39 UTC (rev 211315)
@@ -43,7 +43,7 @@
# Stop for initialization of the safari process, otherwise, open
# command may use the system safari.
time.sleep(3)
- subprocess.Popen(['open', url])
+ subprocess.Popen(['open', '-a', args[0], url])
def close_browsers(self):
super(OSXSafariDriver, self).close_browsers()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
