Title: [211352] trunk/LayoutTests
Revision
211352
Author
y...@yoav.ws
Date
2017-01-29 07:13:44 -0800 (Sun, 29 Jan 2017)

Log Message

Add invalid value tests to Link header handling.
https://bugs.webkit.org/show_bug.cgi?id=167366

Reviewed by Alex Christensen.

* http/tests/preload/download_resources_from_invalid_headers-expected.txt:
* http/tests/preload/resources/download_resources_from_header.php:
* http/tests/preload/resources/invalid_resources_from_header.php:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (211351 => 211352)


--- trunk/LayoutTests/ChangeLog	2017-01-29 14:30:46 UTC (rev 211351)
+++ trunk/LayoutTests/ChangeLog	2017-01-29 15:13:44 UTC (rev 211352)
@@ -1,3 +1,14 @@
+2017-01-29  Yoav Weiss  <y...@yoav.ws>
+
+        Add invalid value tests to Link header handling.
+        https://bugs.webkit.org/show_bug.cgi?id=167366
+
+        Reviewed by Alex Christensen.
+
+        * http/tests/preload/download_resources_from_invalid_headers-expected.txt:
+        * http/tests/preload/resources/download_resources_from_header.php:
+        * http/tests/preload/resources/invalid_resources_from_header.php:
+
 2017-01-29  Gyuyoung Kim  <gyuyoung....@webkit.org>
 
         [EFL] Gardening on 29th Jan.

Modified: trunk/LayoutTests/http/tests/preload/download_resources_from_invalid_headers-expected.txt (211351 => 211352)


--- trunk/LayoutTests/http/tests/preload/download_resources_from_invalid_headers-expected.txt	2017-01-29 14:30:46 UTC (rev 211351)
+++ trunk/LayoutTests/http/tests/preload/download_resources_from_invalid_headers-expected.txt	2017-01-29 15:13:44 UTC (rev 211352)
@@ -1,4 +1,5 @@
 CONSOLE MESSAGE: Refused to load http://localhost:8000/preload/resources/square.png because it does not appear in the img-src directive of the Content Security Policy.
+CONSOLE MESSAGE: <link rel=preload> must have a valid `as` value
 
 
 --------
@@ -19,6 +20,7 @@
 PASS internals.isPreloaded('http://localhost:53/preload/resources/dummy.js'); is true
 PASS internals.isPreloaded('#foobar'); is false
 PASS internals.isPreloaded('../resources/Ahem.ttf'); is false
+PASS internals.isPreloaded('../resources/dummy.js?invalid'); is false
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/http/tests/preload/resources/download_resources_from_header.php (211351 => 211352)


--- trunk/LayoutTests/http/tests/preload/resources/download_resources_from_header.php	2017-01-29 14:30:46 UTC (rev 211351)
+++ trunk/LayoutTests/http/tests/preload/resources/download_resources_from_header.php	2017-01-29 15:13:44 UTC (rev 211352)
@@ -1,6 +1,6 @@
 <?php
 header("Link: <../resources/dummy.js>; rel=preload; as=script", false);
-header("Link:<../resources/dummy.css>; rel=preload; as=style", false);
+header("LiNk:<../resources/dummy.css>; rel=preload; as=style", false);
 header("Link: <../resources/square.png>;rel=preload;as=image", false);
 header("Link: <../resources/Ahem.ttf>; rel=preload; as=font; crossorigin", false);
 header("Link: <../resources/test.mp4>; rel=preload; as=media", false);

Modified: trunk/LayoutTests/http/tests/preload/resources/invalid_resources_from_header.php (211351 => 211352)


--- trunk/LayoutTests/http/tests/preload/resources/invalid_resources_from_header.php	2017-01-29 14:30:46 UTC (rev 211351)
+++ trunk/LayoutTests/http/tests/preload/resources/invalid_resources_from_header.php	2017-01-29 15:13:44 UTC (rev 211352)
@@ -18,6 +18,9 @@
 header("Link: ; rel=preload; as=style", false);
 header("Link <../resources/Ahem.ttf>; rel=preload; as=font; crossorigin", false);
 header("Link: <   ../resources/dummy.js?foobar >; rel=preload; as='", false);
+header("Link: <<../resources/dummy.js?invalid>>; rel=preload; as=script", false);
+header("Link: <../resources/dummy.js?invalid>>; rel=preload; as=script", false);
+header("Link: <<../resources/dummy.js?invalid>; rel=preload; as=script", false);
 ?>
 <!DOCTYPE html>
 <script src=""
@@ -39,4 +42,5 @@
     shouldBeTrue("internals.isPreloaded('http://localhost:53/preload/resources/dummy.js');");
     shouldBeFalse("internals.isPreloaded('#foobar');");
     shouldBeFalse("internals.isPreloaded('../resources/Ahem.ttf');");
+    shouldBeFalse("internals.isPreloaded('../resources/dummy.js?invalid');");
 </script>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to