Title: [211389] trunk/Tools
Revision
211389
Author
aakash_j...@apple.com
Date
2017-01-30 15:21:57 -0800 (Mon, 30 Jan 2017)

Log Message

QueueStatusServer should have an explicit timeout for _fetch_url
https://bugs.webkit.org/show_bug.cgi?id=167467

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer._fetch_url): Add an explicit timeout of 300s.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (211388 => 211389)


--- trunk/Tools/ChangeLog	2017-01-30 23:03:27 UTC (rev 211388)
+++ trunk/Tools/ChangeLog	2017-01-30 23:21:57 UTC (rev 211389)
@@ -1,3 +1,13 @@
+2017-01-30  Aakash Jain  <aakash_j...@apple.com>
+
+        QueueStatusServer should have an explicit timeout for _fetch_url
+        https://bugs.webkit.org/show_bug.cgi?id=167467
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/common/net/statusserver.py:
+        (StatusServer._fetch_url): Add an explicit timeout of 300s.
+
 2017-01-30  Kocsen Chung  <kocsen_ch...@apple.com>
 
         Add support for Trac instances that host multiple projects.

Modified: trunk/Tools/Scripts/webkitpy/common/net/statusserver.py (211388 => 211389)


--- trunk/Tools/Scripts/webkitpy/common/net/statusserver.py	2017-01-30 23:03:27 UTC (rev 211388)
+++ trunk/Tools/Scripts/webkitpy/common/net/statusserver.py	2017-01-30 23:21:57 UTC (rev 211389)
@@ -166,7 +166,7 @@
     def _fetch_url(self, url):
         # FIXME: This should use NetworkTransaction's 404 handling instead.
         try:
-            return urllib2.urlopen(url).read()
+            return urllib2.urlopen(url, timeout=300).read()
         except urllib2.HTTPError, e:
             if e.code == 404:
                 return None
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to