- Revision
- 211393
- Author
- cdu...@apple.com
- Date
- 2017-01-30 16:11:49 -0800 (Mon, 30 Jan 2017)
Log Message
Drop legacy constants on Event interface
https://bugs.webkit.org/show_bug.cgi?id=167602
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop legacy constants on Event interface:
MOUSEDOWN, MOUSEUP, MOUSEOVER, MOUSEOUT, MOUSEMOVE, MOUSEDRAG,
CLICK, DBLCLICK, KEYDOWN, KEYUP, KEYPRESS, DRAGDROP, FOCUS,
BLUR, SELECT, and CHANGE.
Those constants are not used for anything, they are not in the
specification and Chrome / Firefox do not have them.
No new tests, rebaselined existing test.
* dom/Event.idl:
LayoutTests:
Update / Rebaseline existing tests to stop covering those constants.
* fast/dom/constants-expected.txt:
* fast/dom/constants.html:
* fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* http/tests/workers/worker-importScriptsOnError-expected.txt:
* inspector/model/remote-object-get-properties-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (211392 => 211393)
--- trunk/LayoutTests/ChangeLog 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/ChangeLog 2017-01-31 00:11:49 UTC (rev 211393)
@@ -1,3 +1,18 @@
+2017-01-30 Chris Dumez <cdu...@apple.com>
+
+ Drop legacy constants on Event interface
+ https://bugs.webkit.org/show_bug.cgi?id=167602
+
+ Reviewed by Sam Weinig.
+
+ Update / Rebaseline existing tests to stop covering those constants.
+
+ * fast/dom/constants-expected.txt:
+ * fast/dom/constants.html:
+ * fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+ * http/tests/workers/worker-importScriptsOnError-expected.txt:
+ * inspector/model/remote-object-get-properties-expected.txt:
+
2017-01-30 Simon Fraser <simon.fra...@apple.com>
[iOS] position:fixed inside touch-scrollable overflow is mispositioned
Modified: trunk/LayoutTests/fast/dom/constants-expected.txt (211392 => 211393)
--- trunk/LayoutTests/fast/dom/constants-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/fast/dom/constants-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
@@ -44,39 +44,7 @@
PASS: event.CAPTURING_PHASE should be 1 and is.
PASS: event.AT_TARGET should be 2 and is.
PASS: event.BUBBLING_PHASE should be 3 and is.
-PASS: event.MOUSEDOWN should be 1 and is.
-PASS: event.MOUSEUP should be 2 and is.
-PASS: event.MOUSEOVER should be 4 and is.
-PASS: event.MOUSEOUT should be 8 and is.
-PASS: event.MOUSEMOVE should be 16 and is.
-PASS: event.MOUSEDRAG should be 32 and is.
-PASS: event.CLICK should be 64 and is.
-PASS: event.DBLCLICK should be 128 and is.
-PASS: event.KEYDOWN should be 256 and is.
-PASS: event.KEYUP should be 512 and is.
-PASS: event.KEYPRESS should be 1024 and is.
-PASS: event.DRAGDROP should be 2048 and is.
-PASS: event.FOCUS should be 4096 and is.
-PASS: event.BLUR should be 8192 and is.
-PASS: event.SELECT should be 16384 and is.
-PASS: event.CHANGE should be 32768 and is.
PASS: window.Event.NONE should be 0 and is.
PASS: window.Event.CAPTURING_PHASE should be 1 and is.
PASS: window.Event.AT_TARGET should be 2 and is.
PASS: window.Event.BUBBLING_PHASE should be 3 and is.
-PASS: window.Event.MOUSEDOWN should be 1 and is.
-PASS: window.Event.MOUSEUP should be 2 and is.
-PASS: window.Event.MOUSEOVER should be 4 and is.
-PASS: window.Event.MOUSEOUT should be 8 and is.
-PASS: window.Event.MOUSEMOVE should be 16 and is.
-PASS: window.Event.MOUSEDRAG should be 32 and is.
-PASS: window.Event.CLICK should be 64 and is.
-PASS: window.Event.DBLCLICK should be 128 and is.
-PASS: window.Event.KEYDOWN should be 256 and is.
-PASS: window.Event.KEYUP should be 512 and is.
-PASS: window.Event.KEYPRESS should be 1024 and is.
-PASS: window.Event.DRAGDROP should be 2048 and is.
-PASS: window.Event.FOCUS should be 4096 and is.
-PASS: window.Event.BLUR should be 8192 and is.
-PASS: window.Event.SELECT should be 16384 and is.
-PASS: window.Event.CHANGE should be 32768 and is.
Modified: trunk/LayoutTests/fast/dom/constants.html (211392 => 211393)
--- trunk/LayoutTests/fast/dom/constants.html 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/fast/dom/constants.html 2017-01-31 00:11:49 UTC (rev 211393)
@@ -88,43 +88,11 @@
shouldBe("event.CAPTURING_PHASE", 1);
shouldBe("event.AT_TARGET", 2);
shouldBe("event.BUBBLING_PHASE", 3);
- shouldBe("event.MOUSEDOWN", 1);
- shouldBe("event.MOUSEUP", 2);
- shouldBe("event.MOUSEOVER", 4);
- shouldBe("event.MOUSEOUT", 8);
- shouldBe("event.MOUSEMOVE", 16);
- shouldBe("event.MOUSEDRAG", 32);
- shouldBe("event.CLICK", 64);
- shouldBe("event.DBLCLICK", 128);
- shouldBe("event.KEYDOWN", 256);
- shouldBe("event.KEYUP", 512);
- shouldBe("event.KEYPRESS", 1024);
- shouldBe("event.DRAGDROP", 2048);
- shouldBe("event.FOCUS", 4096);
- shouldBe("event.BLUR", 8192);
- shouldBe("event.SELECT", 16384);
- shouldBe("event.CHANGE", 32768);
shouldBe("window.Event.NONE", 0);
shouldBe("window.Event.CAPTURING_PHASE", 1);
shouldBe("window.Event.AT_TARGET", 2);
shouldBe("window.Event.BUBBLING_PHASE", 3);
- shouldBe("window.Event.MOUSEDOWN", 1);
- shouldBe("window.Event.MOUSEUP", 2);
- shouldBe("window.Event.MOUSEOVER", 4);
- shouldBe("window.Event.MOUSEOUT", 8);
- shouldBe("window.Event.MOUSEMOVE", 16);
- shouldBe("window.Event.MOUSEDRAG", 32);
- shouldBe("window.Event.CLICK", 64);
- shouldBe("window.Event.DBLCLICK", 128);
- shouldBe("window.Event.KEYDOWN", 256);
- shouldBe("window.Event.KEYUP", 512);
- shouldBe("window.Event.KEYPRESS", 1024);
- shouldBe("window.Event.DRAGDROP", 2048);
- shouldBe("window.Event.FOCUS", 4096);
- shouldBe("window.Event.BLUR", 8192);
- shouldBe("window.Event.SELECT", 16384);
- shouldBe("window.Event.CHANGE", 32768);
}
</script>
</head>
Modified: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt (211392 => 211393)
--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
@@ -24,25 +24,9 @@
Event object: [object XMLHttpRequestProgressEvent]
Event properties:
AT_TARGET : '2'
-BLUR : '8192'
BUBBLING_PHASE : '3'
CAPTURING_PHASE : '1'
-CHANGE : '32768'
-CLICK : '64'
-DBLCLICK : '128'
-DRAGDROP : '2048'
-FOCUS : '4096'
-KEYDOWN : '256'
-KEYPRESS : '1024'
-KEYUP : '512'
-MOUSEDOWN : '1'
-MOUSEDRAG : '32'
-MOUSEMOVE : '16'
-MOUSEOUT : '8'
-MOUSEOVER : '4'
-MOUSEUP : '2'
NONE : '0'
-SELECT : '16384'
bubbles : 'false'
cancelBubble : 'false'
cancelable : 'false'
Modified: trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt (211392 => 211393)
--- trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
@@ -3,25 +3,9 @@
AT_TARGET: 2,
-BLUR: 8192,
BUBBLING_PHASE: 3,
CAPTURING_PHASE: 1,
-CHANGE: 32768,
-CLICK: 64,
-DBLCLICK: 128,
-DRAGDROP: 2048,
-FOCUS: 4096,
-KEYDOWN: 256,
-KEYPRESS: 1024,
-KEYUP: 512,
-MOUSEDOWN: 1,
-MOUSEDRAG: 32,
-MOUSEMOVE: 16,
-MOUSEOUT: 8,
-MOUSEOVER: 4,
-MOUSEUP: 2,
NONE: 0,
-SELECT: 16384,
bubbles: false,
cancelBubble: false,
cancelable: true,
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (211392 => 211393)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-31 00:11:49 UTC (rev 211393)
@@ -1,3 +1,14 @@
+2017-01-30 Chris Dumez <cdu...@apple.com>
+
+ Drop legacy constants on Event interface
+ https://bugs.webkit.org/show_bug.cgi?id=167602
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/dom/historical-expected.txt:
+
2017-01-27 Joseph Pecoraro <pecor...@apple.com>
Import web-platform-tests/user-timing
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt (211392 => 211393)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
@@ -54,20 +54,20 @@
PASS Node member must be nuked: setUserData
PASS Node member must be nuked: rootNode
PASS Window member must be nuked: attachEvent
-FAIL Event should not have this constant: MOUSEDOWN assert_equals: expected (undefined) undefined but got (number) 1
-FAIL Event should not have this constant: MOUSEUP assert_equals: expected (undefined) undefined but got (number) 2
-FAIL Event should not have this constant: MOUSEOVER assert_equals: expected (undefined) undefined but got (number) 4
-FAIL Event should not have this constant: MOUSEOUT assert_equals: expected (undefined) undefined but got (number) 8
-FAIL Event should not have this constant: MOUSEMOVE assert_equals: expected (undefined) undefined but got (number) 16
-FAIL Event should not have this constant: MOUSEDRAG assert_equals: expected (undefined) undefined but got (number) 32
-FAIL Event should not have this constant: CLICK assert_equals: expected (undefined) undefined but got (number) 64
-FAIL Event should not have this constant: DBLCLICK assert_equals: expected (undefined) undefined but got (number) 128
-FAIL Event should not have this constant: KEYDOWN assert_equals: expected (undefined) undefined but got (number) 256
-FAIL Event should not have this constant: KEYUP assert_equals: expected (undefined) undefined but got (number) 512
-FAIL Event should not have this constant: KEYPRESS assert_equals: expected (undefined) undefined but got (number) 1024
-FAIL Event should not have this constant: DRAGDROP assert_equals: expected (undefined) undefined but got (number) 2048
-FAIL Event should not have this constant: FOCUS assert_equals: expected (undefined) undefined but got (number) 4096
-FAIL Event should not have this constant: BLUR assert_equals: expected (undefined) undefined but got (number) 8192
-FAIL Event should not have this constant: SELECT assert_equals: expected (undefined) undefined but got (number) 16384
-FAIL Event should not have this constant: CHANGE assert_equals: expected (undefined) undefined but got (number) 32768
+PASS Event should not have this constant: MOUSEDOWN
+PASS Event should not have this constant: MOUSEUP
+PASS Event should not have this constant: MOUSEOVER
+PASS Event should not have this constant: MOUSEOUT
+PASS Event should not have this constant: MOUSEMOVE
+PASS Event should not have this constant: MOUSEDRAG
+PASS Event should not have this constant: CLICK
+PASS Event should not have this constant: DBLCLICK
+PASS Event should not have this constant: KEYDOWN
+PASS Event should not have this constant: KEYUP
+PASS Event should not have this constant: KEYPRESS
+PASS Event should not have this constant: DRAGDROP
+PASS Event should not have this constant: FOCUS
+PASS Event should not have this constant: BLUR
+PASS Event should not have this constant: SELECT
+PASS Event should not have this constant: CHANGE
Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (211392 => 211393)
--- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
@@ -269,22 +269,6 @@
CAPTURING_PHASE
AT_TARGET
BUBBLING_PHASE
- MOUSEDOWN
- MOUSEUP
- MOUSEOVER
- MOUSEOUT
- MOUSEMOVE
- MOUSEDRAG
- CLICK
- DBLCLICK
- KEYDOWN
- KEYUP
- KEYPRESS
- DRAGDROP
- FOCUS
- BLUR
- SELECT
- CHANGE
toString
toLocaleString
valueOf
Modified: trunk/Source/WebCore/ChangeLog (211392 => 211393)
--- trunk/Source/WebCore/ChangeLog 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/Source/WebCore/ChangeLog 2017-01-31 00:11:49 UTC (rev 211393)
@@ -1,3 +1,22 @@
+2017-01-30 Chris Dumez <cdu...@apple.com>
+
+ Drop legacy constants on Event interface
+ https://bugs.webkit.org/show_bug.cgi?id=167602
+
+ Reviewed by Sam Weinig.
+
+ Drop legacy constants on Event interface:
+ MOUSEDOWN, MOUSEUP, MOUSEOVER, MOUSEOUT, MOUSEMOVE, MOUSEDRAG,
+ CLICK, DBLCLICK, KEYDOWN, KEYUP, KEYPRESS, DRAGDROP, FOCUS,
+ BLUR, SELECT, and CHANGE.
+
+ Those constants are not used for anything, they are not in the
+ specification and Chrome / Firefox do not have them.
+
+ No new tests, rebaselined existing test.
+
+ * dom/Event.idl:
+
2017-01-30 Simon Fraser <simon.fra...@apple.com>
[iOS] position:fixed inside touch-scrollable overflow is mispositioned
Modified: trunk/Source/WebCore/dom/Event.h (211392 => 211393)
--- trunk/Source/WebCore/dom/Event.h 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/Source/WebCore/dom/Event.h 2017-01-31 00:11:49 UTC (rev 211393)
@@ -59,25 +59,6 @@
BUBBLING_PHASE = 3
};
- enum EventType {
- MOUSEDOWN = 1,
- MOUSEUP = 2,
- MOUSEOVER = 4,
- MOUSEOUT = 8,
- MOUSEMOVE = 16,
- MOUSEDRAG = 32,
- CLICK = 64,
- DBLCLICK = 128,
- KEYDOWN = 256,
- KEYUP = 512,
- KEYPRESS = 1024,
- DRAGDROP = 2048,
- FOCUS = 4096,
- BLUR = 8192,
- SELECT = 16384,
- CHANGE = 32768
- };
-
static Ref<Event> create(const AtomicString& type, bool canBubble, bool cancelable)
{
return adoptRef(*new Event(type, canBubble, cancelable));
Modified: trunk/Source/WebCore/dom/Event.idl (211392 => 211393)
--- trunk/Source/WebCore/dom/Event.idl 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/Source/WebCore/dom/Event.idl 2017-01-31 00:11:49 UTC (rev 211393)
@@ -35,23 +35,6 @@
const unsigned short AT_TARGET = 2;
const unsigned short BUBBLING_PHASE = 3;
- const unsigned short MOUSEDOWN = 1;
- const unsigned short MOUSEUP = 2;
- const unsigned short MOUSEOVER = 4;
- const unsigned short MOUSEOUT = 8;
- const unsigned short MOUSEMOVE = 16;
- const unsigned short MOUSEDRAG = 32;
- const unsigned short CLICK = 64;
- const unsigned short DBLCLICK = 128;
- const unsigned short KEYDOWN = 256;
- const unsigned short KEYUP = 512;
- const unsigned short KEYPRESS = 1024;
- const unsigned short DRAGDROP = 2048;
- const unsigned short FOCUS = 4096;
- const unsigned short BLUR = 8192;
- const unsigned short SELECT = 16384;
- const unsigned short CHANGE = 32768;
-
readonly attribute DOMString type;
readonly attribute EventTarget target;
readonly attribute EventTarget currentTarget;
