Title: [211669] trunk/Source/WebKit2
- Revision
- 211669
- Author
- carlo...@webkit.org
- Date
- 2017-02-04 00:25:10 -0800 (Sat, 04 Feb 2017)
Log Message
Unreviewed. Fix the key shortcut to enable resource usage overlay in GTK+.
The condition to check for CTRL and Shift modifiers is wrong, causing the overlay to be shown on Shit+G and
making it impossible to write a 'G'.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (211668 => 211669)
--- trunk/Source/WebKit2/ChangeLog 2017-02-04 06:03:29 UTC (rev 211668)
+++ trunk/Source/WebKit2/ChangeLog 2017-02-04 08:25:10 UTC (rev 211669)
@@ -1,3 +1,13 @@
+2017-02-04 Carlos Garcia Campos <cgar...@igalia.com>
+
+ Unreviewed. Fix the key shortcut to enable resource usage overlay in GTK+.
+
+ The condition to check for CTRL and Shift modifiers is wrong, causing the overlay to be shown on Shit+G and
+ making it impossible to write a 'G'.
+
+ * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+ (webkitWebViewBaseKeyPressEvent):
+
2017-02-03 Joseph Pecoraro <pecor...@apple.com>
Unreviewed rollout of r211486, r211629.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (211668 => 211669)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2017-02-04 06:03:29 UTC (rev 211668)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2017-02-04 08:25:10 UTC (rev 211669)
@@ -684,7 +684,7 @@
WebKitWebViewBasePrivate* priv = webViewBase->priv;
#if ENABLE(DEVELOPER_MODE) && OS(LINUX)
- if ((keyEvent->state & (GDK_CONTROL_MASK | GDK_SHIFT_MASK)) && keyEvent->keyval == GDK_KEY_G) {
+ if ((keyEvent->state & GDK_CONTROL_MASK) && (keyEvent->state & GDK_SHIFT_MASK) && keyEvent->keyval == GDK_KEY_G) {
auto& preferences = priv->pageProxy->preferences();
preferences.setResourceUsageOverlayVisible(!preferences.resourceUsageOverlayVisible());
priv->shouldForwardNextKeyEvent = FALSE;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
