Title: [211724] trunk
- Revision
- 211724
- Author
- commit-qu...@webkit.org
- Date
- 2017-02-06 08:19:43 -0800 (Mon, 06 Feb 2017)
Log Message
[Modern Media Controls] Add a backdrop filter to the start button on macOS
https://bugs.webkit.org/show_bug.cgi?id=167879
<rdar://problem/30375174>
Patch by Antoine Quint <grao...@apple.com> on 2017-02-06
Reviewed by Eric Carlson.
Source/WebCore:
Add a backdrop filter to the start button on macOS.
Test: media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html
* Modules/modern-media-controls/controls/macos-inline-media-controls.css:
(.media-controls.mac.inline > button.start > div):
LayoutTests:
Add a new test that checks that the expected backdrop filter is applied to the start button on macOS.
* media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style-expected.txt: Added.
* media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (211723 => 211724)
--- trunk/LayoutTests/ChangeLog 2017-02-06 16:16:53 UTC (rev 211723)
+++ trunk/LayoutTests/ChangeLog 2017-02-06 16:19:43 UTC (rev 211724)
@@ -1,5 +1,18 @@
2017-02-06 Antoine Quint <grao...@apple.com>
+ [Modern Media Controls] Add a backdrop filter to the start button on macOS
+ https://bugs.webkit.org/show_bug.cgi?id=167879
+ <rdar://problem/30375174>
+
+ Reviewed by Eric Carlson.
+
+ Add a new test that checks that the expected backdrop filter is applied to the start button on macOS.
+
+ * media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style-expected.txt: Added.
+ * media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html: Added.
+
+2017-02-06 Antoine Quint <grao...@apple.com>
+
[Modern Media Controls] Bring fullscreen controls up to spec
https://bugs.webkit.org/show_bug.cgi?id=167875
<rdar://problem/29611222>
Added: trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style-expected.txt (0 => 211724)
--- trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style-expected.txt 2017-02-06 16:19:43 UTC (rev 211724)
@@ -0,0 +1,10 @@
+Testing the MacOSInlineMediaControls computed styles for the start button.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS getComputedStyle(mediaControls.startButton.element.firstElementChild).webkitBackdropFilter is "saturate(1.8) blur(20px)"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html (0 => 211724)
--- trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html 2017-02-06 16:19:43 UTC (rev 211724)
@@ -0,0 +1,29 @@
+<script src=""
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<body>
+<script type="text/_javascript_">
+
+description("Testing the <code>MacOSInlineMediaControls</code> computed styles for the start button.");
+
+window.jsTestIsAsync = true;
+
+const mediaControls = new MacOSInlineMediaControls({ width: 680, height: 300 });
+mediaControls.showsStartButton = true;
+document.body.appendChild(mediaControls.element);
+
+let style;
+scheduler.frameDidFire = function()
+{
+ if (mediaControls.startButton.element.getBoundingClientRect().width == 0)
+ return;
+
+ shouldBeEqualToString("getComputedStyle(mediaControls.startButton.element.firstElementChild).webkitBackdropFilter", "saturate(1.8) blur(20px)");
+
+ mediaControls.element.remove();
+ finishMediaControlsTest();
+};
+
+</script>
+<script src=""
+</body>
Modified: trunk/Source/WebCore/ChangeLog (211723 => 211724)
--- trunk/Source/WebCore/ChangeLog 2017-02-06 16:16:53 UTC (rev 211723)
+++ trunk/Source/WebCore/ChangeLog 2017-02-06 16:19:43 UTC (rev 211724)
@@ -1,5 +1,20 @@
2017-02-06 Antoine Quint <grao...@apple.com>
+ [Modern Media Controls] Add a backdrop filter to the start button on macOS
+ https://bugs.webkit.org/show_bug.cgi?id=167879
+ <rdar://problem/30375174>
+
+ Reviewed by Eric Carlson.
+
+ Add a backdrop filter to the start button on macOS.
+
+ Test: media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html
+
+ * Modules/modern-media-controls/controls/macos-inline-media-controls.css:
+ (.media-controls.mac.inline > button.start > div):
+
+2017-02-06 Antoine Quint <grao...@apple.com>
+
[Modern Media Controls] Bring fullscreen controls up to spec
https://bugs.webkit.org/show_bug.cgi?id=167875
<rdar://problem/29611222>
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css (211723 => 211724)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css 2017-02-06 16:16:53 UTC (rev 211723)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css 2017-02-06 16:19:43 UTC (rev 211724)
@@ -57,6 +57,10 @@
-webkit-backdrop-filter: saturate(180%) blur(20px);
}
+.media-controls.mac.inline > button.start > div {
+ -webkit-backdrop-filter: saturate(180%) blur(20px);
+}
+
/* Controls placement */
.media-controls.mac.inline button.play-pause {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
