Title: [211733] trunk/Source/WebCore
Revision
211733
Author
carlo...@webkit.org
Date
2017-02-06 09:49:18 -0800 (Mon, 06 Feb 2017)

Log Message

Resource usage overlay should ignore mouse events outside bounds by default
https://bugs.webkit.org/show_bug.cgi?id=167874

Reviewed by Andreas Kling.

It's overriding the default causing that the first click after the overlay is shown is always handled by the
overlay even when clicked outside bounds. It should only be set false while dragging.

* page/ResourceUsageOverlay.cpp:
(WebCore::ResourceUsageOverlay::initialize):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (211732 => 211733)


--- trunk/Source/WebCore/ChangeLog	2017-02-06 17:47:02 UTC (rev 211732)
+++ trunk/Source/WebCore/ChangeLog	2017-02-06 17:49:18 UTC (rev 211733)
@@ -1,3 +1,16 @@
+2017-02-06  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        Resource usage overlay should ignore mouse events outside bounds by default
+        https://bugs.webkit.org/show_bug.cgi?id=167874
+
+        Reviewed by Andreas Kling.
+
+        It's overriding the default causing that the first click after the overlay is shown is always handled by the
+        overlay even when clicked outside bounds. It should only be set false while dragging.
+
+        * page/ResourceUsageOverlay.cpp:
+        (WebCore::ResourceUsageOverlay::initialize):
+
 2017-02-06  Antti Koivisto  <an...@apple.com>
 
         CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::Node::invalidateStyle

Modified: trunk/Source/WebCore/page/ResourceUsageOverlay.cpp (211732 => 211733)


--- trunk/Source/WebCore/page/ResourceUsageOverlay.cpp	2017-02-06 17:47:02 UTC (rev 211732)
+++ trunk/Source/WebCore/page/ResourceUsageOverlay.cpp	2017-02-06 17:49:18 UTC (rev 211733)
@@ -71,7 +71,6 @@
 #endif
 
     m_overlay->setFrame(initialRect);
-    m_overlay->setShouldIgnoreMouseEventsOutsideBounds(false);
     m_page.mainFrame().pageOverlayController().installPageOverlay(*m_overlay, PageOverlay::FadeMode::DoNotFade);
     platformInitialize();
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to