Title: [211854] trunk/Source/WebCore
- Revision
- 211854
- Author
- carlo...@webkit.org
- Date
- 2017-02-07 22:54:01 -0800 (Tue, 07 Feb 2017)
Log Message
REGRESSION(r210740): [GTK] 2.15 broke embedded videos in GNOME's yelp app
https://bugs.webkit.org/show_bug.cgi?id=167887
Reviewed by Michael Catanzaro.
Update the m_renderingCanBeAccelerated when accelerated rendering state changes.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (211853 => 211854)
--- trunk/Source/WebCore/ChangeLog 2017-02-08 06:41:12 UTC (rev 211853)
+++ trunk/Source/WebCore/ChangeLog 2017-02-08 06:54:01 UTC (rev 211854)
@@ -1,5 +1,19 @@
2017-02-07 Carlos Garcia Campos <cgar...@igalia.com>
+ REGRESSION(r210740): [GTK] 2.15 broke embedded videos in GNOME's yelp app
+ https://bugs.webkit.org/show_bug.cgi?id=167887
+
+ Reviewed by Michael Catanzaro.
+
+ Update the m_renderingCanBeAccelerated when accelerated rendering state changes.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged):
+ (WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
+2017-02-07 Carlos Garcia Campos <cgar...@igalia.com>
+
[GTK] Handle extended colors in cairo and texture mapper backends
https://bugs.webkit.org/show_bug.cgi?id=167943
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (211853 => 211854)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2017-02-08 06:41:12 UTC (rev 211853)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2017-02-08 06:54:01 UTC (rev 211854)
@@ -613,6 +613,11 @@
player->m_notifier.notify(MainThreadNotification::MuteChanged, [player] { player->notifyPlayerOfMute(); });
}
+void MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged()
+{
+ m_renderingCanBeAccelerated = m_player && m_player->client().mediaPlayerAcceleratedCompositingEnabled() && m_player->client().mediaPlayerRenderingCanBeAccelerated(m_player);
+}
+
#if USE(TEXTURE_MAPPER_GL) && !USE(COORDINATED_GRAPHICS_MULTIPROCESS)
void MediaPlayerPrivateGStreamerBase::updateTexture(BitmapTextureGL& texture, GstVideoInfo& videoInfo)
{
@@ -1105,8 +1110,7 @@
GstElement* MediaPlayerPrivateGStreamerBase::createVideoSink()
{
- m_renderingCanBeAccelerated = supportsAcceleratedRendering() && m_player->client().mediaPlayerAcceleratedCompositingEnabled()
- && m_player->client().mediaPlayerRenderingCanBeAccelerated(m_player);
+ acceleratedRenderingStateChanged();
#if USE(GSTREAMER_GL)
if (m_renderingCanBeAccelerated)
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h (211853 => 211854)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h 2017-02-08 06:41:12 UTC (rev 211853)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h 2017-02-08 06:54:01 UTC (rev 211854)
@@ -105,6 +105,8 @@
unsigned audioDecodedByteCount() const override;
unsigned videoDecodedByteCount() const override;
+ void acceleratedRenderingStateChanged() override;
+
#if USE(TEXTURE_MAPPER_GL) && !USE(COORDINATED_GRAPHICS)
PlatformLayer* platformLayer() const override { return const_cast<MediaPlayerPrivateGStreamerBase*>(this); }
#if PLATFORM(WIN_CAIRO)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
